xfs
[Top] [All Lists]

Re: [PATCH 6/6] xfs: pad xfs_attr_leaf_name_remote to avoid tripping on

To: Dave Chinner <david@xxxxxxxxxxxxx>
Subject: Re: [PATCH 6/6] xfs: pad xfs_attr_leaf_name_remote to avoid tripping on m68k
From: Christoph Hellwig <hch@xxxxxxxxxxxxx>
Date: Mon, 7 Mar 2016 23:02:08 -0800
Cc: Christoph Hellwig <hch@xxxxxxxxxxxxx>, xfs@xxxxxxxxxxx
Delivered-to: xfs@xxxxxxxxxxx
In-reply-to: <20160308035648.GV30721@dastard>
References: <1457300990-18300-1-git-send-email-david@xxxxxxxxxxxxx> <1457300990-18300-7-git-send-email-david@xxxxxxxxxxxxx> <20160307162858.GE19784@xxxxxxxxxxxxx> <20160308035648.GV30721@dastard>
User-agent: Mutt/1.5.24 (2015-08-30)
On Tue, Mar 08, 2016 at 02:56:48PM +1100, Dave Chinner wrote:
> > I think using a small fixed size array as a variable sized array
> > is not a good idea, especially with increasinly "smart" optimizing
> > compilers.  I'd rather take this structure out the size checking,
> > and then move it to a C99 VLA instead of the size 1 hack in the long
> > run.
> 
> I don't have the time right now to do this, so I'm just going to
> drop it - I'd guess the overlap between m68k and XFS users is so
> close to zero that it just doesn't matter.  I'll just drop this
> patch for now.

I'll send you a patch for it.

<Prev in Thread] Current Thread [Next in Thread>