| To: | Christoph Hellwig <hch@xxxxxxxxxxxxx> |
|---|---|
| Subject: | Re: [PATCH] xfs/259: disable CRC if testing with 512 bytes block size |
| From: | Eryu Guan <eguan@xxxxxxxxxx> |
| Date: | Mon, 7 Mar 2016 11:04:44 +0800 |
| Cc: | fstests@xxxxxxxxxxxxxxx, xfs@xxxxxxxxxxx |
| Delivered-to: | xfs@xxxxxxxxxxx |
| In-reply-to: | <20160305204517.GA10065@xxxxxxxxxxxxx> |
| References: | <1456937518-20505-1-git-send-email-eguan@xxxxxxxxxx> <20160305204517.GA10065@xxxxxxxxxxxxx> |
| User-agent: | Mutt/1.5.24 (2015-08-30) |
On Sat, Mar 05, 2016 at 12:45:17PM -0800, Christoph Hellwig wrote: > This will force crcs off for all the blocksizes. We should > either always skip 512 bytes, or disable crcs only for the 512 byte > inode size case. The first seems either, but the second would give > better test coverage. Thanks for the review! I think the test itself has already disabled crc for 512 block size fs, and this patch disables crc only if the TEST_DEV has no crc, so it just fixes a corner case in this crc detecting, and doesn't reduce the test coverage. Thanks, Eryu |
| <Prev in Thread] | Current Thread | [Next in Thread> |
|---|---|---|
| ||
| Previous by Date: | [ANNOUNCE] xfs: for-next rebased to 3c1a79f, Dave Chinner |
|---|---|
| Next by Date: | Re: [PATCH 12/12] block: test fallocate for block devices, Darrick J. Wong |
| Previous by Thread: | Re: [PATCH] xfs/259: disable CRC if testing with 512 bytes block size, Christoph Hellwig |
| Next by Thread: | [PATCH] vfs: support FS_XFLAG_REFLINK and FS_XFLAG_COWEXTSIZE, Darrick J. Wong |
| Indexes: | [Date] [Thread] [Top] [All Lists] |