xfs
[Top] [All Lists]

Re: xfs resize: primary superblock is not updated immediately

To: Alex Lyakas <alex@xxxxxxxxxxxxxxxxx>
Subject: Re: xfs resize: primary superblock is not updated immediately
From: Dave Chinner <david@xxxxxxxxxxxxx>
Date: Fri, 4 Mar 2016 08:31:08 +1100
Cc: Christoph Hellwig <hch@xxxxxxxxxxxxx>, Danny Shavit <danny@xxxxxxxxxxxxxxxxx>, Shyam Kaushik <shyam@xxxxxxxxxxxxxxxxx>, Yair Hershko <yair@xxxxxxxxxxxxxxxxx>, xfs@xxxxxxxxxxx
Delivered-to: xfs@xxxxxxxxxxx
In-reply-to: <E965894DE8D542788CCE98F72C218C05@alyakaslap>
References: <3685DFAD20214109878873CF81232704@alyakaslap> <20160222212019.GI25832@dastard> <CAOcd+r1XY2kcp+qJ=mPOAQSmb90QUnLfmT3-FkMjQN_+Ejmt8A@xxxxxxxxxxxxxx> <20160222235628.GK25832@dastard> <D5578D3E98EE48B88EA9A1126B671155@alyakaslap> <20160223225926.GN25832@dastard> <BC0CC25E00CE4CEDA1FFDFC0A2F38742@alyakaslap> <20160229211628.GK29057@dastard> <20160301072011.GF30721@dastard> <E965894DE8D542788CCE98F72C218C05@alyakaslap>
User-agent: Mutt/1.5.21 (2010-09-15)
On Thu, Mar 03, 2016 at 11:18:43AM +0200, Alex Lyakas wrote:
> Hello Dave,
> Thanks for the patch! I confirm that it fixes the scenario.
> 
> At [1] please find all the blknos that are being used during the log
> recovery (if that's of any interest).
....
> Mar  3 11:17:41 vc-00-00-350-dev kernel: [   68.129739]
> _xfs_buf_find: blkno=200705 eofs=204800 >m_sb.sb_dblocks=25600
> Mar  3 11:17:41 vc-00-00-350-dev kernel: [   68.129746]
> _xfs_buf_find: blkno=200705 eofs=204800 >m_sb.sb_dblocks=25600

Where is the warning that this block is out of range?

And why didn't recovery fail at this point because the block
requested is out of range and so the buffer lookup should have
failed?

Cheers,

Dave.
-- 
Dave Chinner
david@xxxxxxxxxxxxx

<Prev in Thread] Current Thread [Next in Thread>