| To: | Luis de Bethencourt <luisbg@xxxxxxxxxxxxxxx> |
|---|---|
| Subject: | Re: [PATCH] xfs: remove impossible condition |
| From: | Christoph Hellwig <hch@xxxxxxxxxxxxx> |
| Date: | Tue, 1 Mar 2016 04:08:14 -0800 |
| Cc: | linux-kernel@xxxxxxxxxxxxxxx, cmaiolino@xxxxxxxxxx, darrick.wong@xxxxxxxxxx, namjae.jeon@xxxxxxxxxxx, bfoster@xxxxxxxxxx, sandeen@xxxxxxxxxxx, xfs@xxxxxxxxxxx, billodo@xxxxxxxxxx |
| Delivered-to: | xfs@xxxxxxxxxxx |
| In-reply-to: | <1456404237-18169-1-git-send-email-luisbg@xxxxxxxxxxxxxxx> |
| References: | <1456404237-18169-1-git-send-email-luisbg@xxxxxxxxxxxxxxx> |
| User-agent: | Mutt/1.5.24 (2015-08-30) |
On Thu, Feb 25, 2016 at 12:43:57PM +0000, Luis de Bethencourt wrote: > bp_release is set to 0 just before the breakpoint of the for loop before > the conditional check (in line 458). The other breakpoint is a goto that > skips the dead code. Yes, this looks correct: Reviewed-by: Christoph Hellwig <hch@xxxxxx> The whole code around this is rather grotty and could use some more work, though.. |
| <Prev in Thread] | Current Thread | [Next in Thread> |
|---|---|---|
| ||
| Previous by Date: | Custom Shaped USB drives, Christina Devlin |
|---|---|
| Next by Date: | Re: [PATCH] xfs_io: Prevent devide by zero from {pread,pwrite}_random, Christoph Hellwig |
| Previous by Thread: | Custom Shaped USB drives, Christina Devlin |
| Next by Thread: | Re: [PATCH] xfs: remove impossible condition, Luis de Bethencourt |
| Indexes: | [Date] [Thread] [Top] [All Lists] |