xfs
[Top] [All Lists]

Re: [PATCH 11/15] xfs: move v1 inode conversion to xfs_inode_from_disk

To: Dave Chinner <david@xxxxxxxxxxxxx>
Subject: Re: [PATCH 11/15] xfs: move v1 inode conversion to xfs_inode_from_disk
From: Christoph Hellwig <hch@xxxxxxxxxxxxx>
Date: Wed, 17 Feb 2016 00:33:08 -0800
Cc: Christoph Hellwig <hch@xxxxxxxxxxxxx>, xfs@xxxxxxxxxxx
Delivered-to: xfs@xxxxxxxxxxx
In-reply-to: <20160217083000.GG19486@dastard>
References: <1455693652-3899-1-git-send-email-david@xxxxxxxxxxxxx> <1455693652-3899-12-git-send-email-david@xxxxxxxxxxxxx> <20160217073204.GB16363@xxxxxxxxxxxxx> <20160217074821.GD19486@dastard> <20160217083000.GG19486@dastard>
User-agent: Mutt/1.5.24 (2015-08-30)
On Wed, Feb 17, 2016 at 07:30:00PM +1100, Dave Chinner wrote:
> > Yeah, probably. I'll have to look at this a bit closer - I think I
> > assumed that we're always going to have v2 inode format here (like
> > we do in the kernel), but that may not be true. I'll have a closer
> > look.
> 
> having a closer look, the XFS_SB_VERSION_NLINKBIT that is set here
> in sbversion is never used, so I just removed it. I also changed it
> back to using the converted in-memory link count so it's always
> going to be correct now. Now it is just:
> 
> +       setlink_inode(id, xino.i_d.di_nlink, type == DBM_DIR, security);

Great.  With that and the other nitpicks address:

Reviewed-by: Christoph Hellwig <hch@xxxxxx>

for the whole series.

<Prev in Thread] Current Thread [Next in Thread>