Re: [PATCH] xfs: fix two memory leaks in xfs_attr

xfs

Re: [PATCH] xfs: fix two memory leaks in xfs_attr_list.c error paths

To:	Mateusz Guzik <mguzik@xxxxxxxxxx>
Subject:	Re: [PATCH] xfs: fix two memory leaks in xfs_attr_list.c error paths
From:	Christoph Hellwig <hch@xxxxxxxxxxxxx>
Date:	Fri, 12 Feb 2016 01:27:35 -0800
Cc:	xfs@xxxxxxxxxxx, stable@xxxxxxxxxxxxxxx
Delivered-to:	xfs@xxxxxxxxxxx
In-reply-to:	<1455129337-19255-1-git-send-email-mguzik@xxxxxxxxxx>
References:	<1455129337-19255-1-git-send-email-mguzik@xxxxxxxxxx>
User-agent:	Mutt/1.5.24 (2015-08-30)

On Wed, Feb 10, 2016 at 07:35:37PM +0100, Mateusz Guzik wrote:
> This plugs 2 trivial leaks in xfs_attr_shortform_list and
> xfs_attr3_leaf_list_int.

Can you please add a out: label before the kmem_free at the end of
the function, return the actual error value there and make all others
returns after the kmem_alloc jump to that label?

[More with this subject...]

<Prev in Thread]	Current Thread	[Next in Thread>
[PATCH] xfs: fix two memory leaks in xfs_attr_list.c error paths, Mateusz Guzik Re: [PATCH] xfs: fix two memory leaks in xfs_attr_list.c error paths, Eric Sandeen Re: [PATCH] xfs: fix two memory leaks in xfs_attr_list.c error paths, Christoph Hellwig <=

Previous by Date:	Re: [PATCH 12/32] dio: unwritten conversion bug tests, Dave Chinner
Next by Date:	Re: [PATCH 2/6] xfs: remove xfs_cancel_ioend, Christoph Hellwig
Previous by Thread:	Re: [PATCH] xfs: fix two memory leaks in xfs_attr_list.c error paths, Eric Sandeen
Next by Thread:	[PATCH 2/2 v3] xfs_repair: new secondary superblock search method, Bill O'Donnell
Indexes:	[Date] [Thread] [Top] [All Lists]