Re: [PATCH 12/32] dio: unwritten conversion bug tests

To:	"Darrick J. Wong" <darrick.wong@xxxxxxxxxx>
Subject:	Re: [PATCH 12/32] dio: unwritten conversion bug tests
From:	Dave Chinner <david@xxxxxxxxxxxxx>
Date:	Fri, 12 Feb 2016 14:52:53 +1100
Cc:	linux-btrfs@xxxxxxxxxxxxxxx, fstests@xxxxxxxxxxxxxxx, xfs@xxxxxxxxxxx
Delivered-to:	xfs@xxxxxxxxxxx
In-reply-to:	<20160211234037.2202.93885.stgit@xxxxxxxxxxxxxxxx>
References:	<20160211233916.2202.40961.stgit@xxxxxxxxxxxxxxxx> <20160211234037.2202.93885.stgit@xxxxxxxxxxxxxxxx>
User-agent:	Mutt/1.5.21 (2010-09-15)

On Thu, Feb 11, 2016 at 03:40:37PM -0800, Darrick J. Wong wrote:
> Check that we don't expose old disk contents when a directio write to
> an unwritten extent fails due to IO errors.  This primarily affects
> XFS and ext4.
> 
> Signed-off-by: Darrick J. Wong <darrick.wong@xxxxxxxxxx>

aiocp.c: In function 'main':
aiocp.c:407:1: warning: format '%d' expects argument of type 'int', but 
argument 3 has type 'off_t' [-Wformat=]
 printf("tocopy=%d len=%d blk=%d\n", tocopy, length, aio_blksize);
 ^

Followup patch is fine, I'll commit as is.

Cheers,

Dave.
-- 
Dave Chinner
david@xxxxxxxxxxxxx

<Prev in Thread]	Current Thread	[Next in Thread>
[PATCH 02/32] xfstests: filter whitespace in 128 and 132, (continued) [PATCH 02/32] xfstests: filter whitespace in 128 and 132, Darrick J. Wong [PATCH 03/32] xfstests: make _scratch_mkfs_blocksized usable, Darrick J. Wong [PATCH 04/32] reflink: remove redundant filesystem checks from the end of the tests, Darrick J. Wong [PATCH 05/32] reflink: remove unnecessary umounts from test code, Darrick J. Wong [PATCH 06/32] common/dmerror: add some more dmerror routines, Darrick J. Wong [PATCH 07/32] common: create _require_test_program to look for programs in src/, Darrick J. Wong [PATCH 08/32] common: provide a method to repair the scratch fs, Darrick J. Wong [PATCH 09/32] reflink: refactor mixed block creation code, Darrick J. Wong [PATCH 11/32] reflink: add _require_odirect to the directio tests, Darrick J. Wong [PATCH 12/32] dio: unwritten conversion bug tests, Darrick J. Wong Re: [PATCH 12/32] dio: unwritten conversion bug tests, Dave Chinner <= Re: [PATCH 12/32] dio: unwritten conversion bug tests, Theodore Ts'o Re: [PATCH 12/32] dio: unwritten conversion bug tests, Dave Chinner Re: [PATCH 12/32] dio: unwritten conversion bug tests, Darrick J. Wong [PATCH 13/32] reflink: test intersecting CoW and falloc/fpunch/fzero/fcollapse/finsert/ftrunc, Darrick J. Wong [PATCH 10/32] reflink: fix style problems in existing tests, Darrick J. Wong [PATCH 14/32] reflink: test CoW behavior with IO errors, Darrick J. Wong [PATCH 15/32] reflink: test CoW operations against the source file, Darrick J. Wong [PATCH 16/32] reflink: ensure that we can handle reflinking a lot of extents, Darrick J. Wong [PATCH 17/32] xfs: more reflink tests, Darrick J. Wong [PATCH 18/32] xfs/122: support refcount/rmap data structures, Darrick J. Wong

Previous by Date:	[GIT PULL] xfs: fixes for 4.5-rc4, Dave Chinner
Next by Date:	Re: [PATCH] xfs: fix two memory leaks in xfs_attr_list.c error paths, Christoph Hellwig
Previous by Thread:	[PATCH 12/32] dio: unwritten conversion bug tests, Darrick J. Wong
Next by Thread:	Re: [PATCH 12/32] dio: unwritten conversion bug tests, Theodore Ts'o
Indexes:	[Date] [Thread] [Top] [All Lists]