xfs
[Top] [All Lists]

Re: [PATCH v2 0/2] DAX bdev fixes - move flushing calls to FS

To: Ross Zwisler <ross.zwisler@xxxxxxxxxxxxxxx>, Jan Kara <jack@xxxxxxx>, linux-kernel@xxxxxxxxxxxxxxx, Theodore Ts'o <tytso@xxxxxxx>, Alexander Viro <viro@xxxxxxxxxxxxxxxxxx>, Andreas Dilger <adilger.kernel@xxxxxxxxx>, Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx>, Dan Williams <dan.j.williams@xxxxxxxxx>, Jan Kara <jack@xxxxxxxx>, Matthew Wilcox <willy@xxxxxxxxxxxxxxx>, linux-ext4@xxxxxxxxxxxxxxx, linux-fsdevel@xxxxxxxxxxxxxxx, linux-mm@xxxxxxxxx, linux-nvdimm@xxxxxxxxxxxx, xfs@xxxxxxxxxxx
Subject: Re: [PATCH v2 0/2] DAX bdev fixes - move flushing calls to FS
From: Dave Chinner <david@xxxxxxxxxxxxx>
Date: Fri, 12 Feb 2016 07:50:49 +1100
Delivered-to: xfs@xxxxxxxxxxx
In-reply-to: <20160211194922.GA5260@xxxxxxxxxxxxxxx>
References: <1455137336-28720-1-git-send-email-ross.zwisler@xxxxxxxxxxxxxxx> <20160211124304.GI21760@xxxxxxxxxxxxx> <20160211194922.GA5260@xxxxxxxxxxxxxxx>
User-agent: Mutt/1.5.21 (2010-09-15)
On Thu, Feb 11, 2016 at 12:49:22PM -0700, Ross Zwisler wrote:
> I think the plan of unsetting S_DAX on bdev->bd_inode when we mount will save
> us from this, as long as we do it super early in the mount process.

I think that S_DAX should not be set on the block device by default
in the first place. If we've been surprised by unexpected behaviour,
then I'm sure there are going to be other surprises waiting for us.
DAX default policy should be opt-in, not opt-out.

Cheers,

Dave.
-- 
Dave Chinner
david@xxxxxxxxxxxxx

<Prev in Thread] Current Thread [Next in Thread>