xfs
[Top] [All Lists]

Re: [PATCH 1/3] quota: Add support for ->get_nextdqblk() for VFS quota

To: Dave Chinner <david@xxxxxxxxxxxxx>
Subject: Re: [PATCH 1/3] quota: Add support for ->get_nextdqblk() for VFS quota
From: Jan Kara <jack@xxxxxxx>
Date: Mon, 8 Feb 2016 15:27:49 +0100
Cc: Jan Kara <jack@xxxxxxx>, linux-fsdevel@xxxxxxxxxxxxxxx, ocfs2-devel@xxxxxxxxxxxxxx, Mark Fasheh <mfasheh@xxxxxxxx>, Joel Becker <jlbec@xxxxxxxxxxxx>, xfs@xxxxxxxxxxx
Delivered-to: xfs@xxxxxxxxxxx
In-reply-to: <20160205010519.GJ459@dastard>
References: <1454596087-6814-1-git-send-email-jack@xxxxxxx> <1454596087-6814-2-git-send-email-jack@xxxxxxx> <20160205010519.GJ459@dastard>
User-agent: Mutt/1.5.24 (2015-08-30)
On Fri 05-02-16 12:05:19, Dave Chinner wrote:
> On Thu, Feb 04, 2016 at 03:28:05PM +0100, Jan Kara wrote:
> > Add infrastructure for supporting get_nextdqblk() callback for VFS
> > quotas. Translate the operation into a callback to appropriate
> > filesystem and consequently to quota format callback.
> > 
> > Signed-off-by: Jan Kara <jack@xxxxxxx>
> 
> I'm a little confused here. What patchset is this dependent on? i.e.
> what introduces the ->get_nextdqblk method?

It depends on the patches Eric sent which introduce ->get_nextdqblk.

> The patches I currently have in my XFS working tree introduce this
> (quota: add new quotactl Q_XGETNEXTQUOTA) and everythign else is
> dependent on this. I looked a coupl eof days ago and I wasnt' able
> to find this in your tree.

Yeah, I have this patch as well, I just didn't push out.

> I'd much prefer that one of us publish a stable branch with just the
> quotactl() infrastructure (i.e. commands and bits up to the
> ->get_nextdqblk() callback) that we can then both base the different
> subsystem implementations off, rather than one of us having to pull
> in a whole tree of changes just to get the one commit we need...

Sure, I have pushed out:

'getnextquota' branch into my tree

git://git.kernel.org/pub/scm/linux/kernel/git/jack/linux-fs.git 

which contains the patches from Eric I carry (including fixups in comments
other minor stuff I have found during final review). Can you please base
XFS patches on top of this branch? Thanks!

                                                                Honza
-- 
Jan Kara <jack@xxxxxxxx>
SUSE Labs, CR

<Prev in Thread] Current Thread [Next in Thread>