| To: | Dave Chinner <david@xxxxxxxxxxxxx> |
|---|---|
| Subject: | Re: [PATCH 5/9] xfs: reinitialise recycled VFS inode correctly |
| From: | Christoph Hellwig <hch@xxxxxxxxxxxxx> |
| Date: | Mon, 8 Feb 2016 01:33:48 -0800 |
| Cc: | xfs@xxxxxxxxxxx |
| Delivered-to: | xfs@xxxxxxxxxxx |
| In-reply-to: | <1454905461-2773-6-git-send-email-david@xxxxxxxxxxxxx> |
| References: | <1454905461-2773-1-git-send-email-david@xxxxxxxxxxxxx> <1454905461-2773-6-git-send-email-david@xxxxxxxxxxxxx> |
| User-agent: | Mutt/1.5.24 (2015-08-30) |
On Mon, Feb 08, 2016 at 03:24:17PM +1100, Dave Chinner wrote: > From: Dave Chinner <dchinner@xxxxxxxxxx> > > Now that we keep certain on-disk information in the VFS inode rather > than in a separate XFS specific stucture, we have to be careful of > the VFS code clearing that information when we re-initialise > reclaimable cached inodes during lookup. If we don't do this, then > we lose critical information from the inode and that results in > corruption being detected. Might be worth to use future tense here? Or maybe just fold it into the next patch. Either way: Reviewed-by: Christoph Hellwig <hch@xxxxxx> |
| Previous by Date: | Re: [PATCH 4/9] xfs: move v1 inode conversion to xfs_inode_from_disk, Christoph Hellwig |
|---|---|
| Next by Date: | Re: [PATCH 6/9] xfs: use vfs inode nlink field everywhere, Christoph Hellwig |
| Previous by Thread: | [PATCH 5/9] xfs: reinitialise recycled VFS inode correctly, Dave Chinner |
| Next by Thread: | Re: [PATCH 5/9] xfs: reinitialise recycled VFS inode correctly, Brian Foster |
| Indexes: | [Date] [Thread] [Top] [All Lists] |