| To: | Dave Chinner <david@xxxxxxxxxxxxx> |
|---|---|
| Subject: | Re: [PATCH 2/9] xfs: remove timestamps from incore inode |
| From: | Christoph Hellwig <hch@xxxxxxxxxxxxx> |
| Date: | Mon, 8 Feb 2016 01:28:17 -0800 |
| Cc: | xfs@xxxxxxxxxxx |
| Delivered-to: | xfs@xxxxxxxxxxx |
| In-reply-to: | <1454905461-2773-3-git-send-email-david@xxxxxxxxxxxxx> |
| References: | <1454905461-2773-1-git-send-email-david@xxxxxxxxxxxxx> <1454905461-2773-3-git-send-email-david@xxxxxxxxxxxxx> |
| User-agent: | Mutt/1.5.24 (2015-08-30) |
> + /* > + * time is signed, so need to convert to signed 32 bit before > + * storing in inode timestamp which may be 64 bit. Otherwise > + * a time before epoch is converted to a time long after epoch > + * on 64 bit systems. > + */ Time should be captizalized at the beginning of the comment. Otherwise looks fine: Reviewed-by: Christoph Hellwig <hch@xxxxxx> |
| Previous by Date: | Re: [PATCH 1/9] xfs: introduce inode log format object, Christoph Hellwig |
|---|---|
| Next by Date: | Re: [PATCH 3/9] xfs: cull unnecessary icdinode fields, Christoph Hellwig |
| Previous by Thread: | [PATCH 2/9] xfs: remove timestamps from incore inode, Dave Chinner |
| Next by Thread: | [PATCH 8/9] xfs: move di_changecount to VFS inode, Dave Chinner |
| Indexes: | [Date] [Thread] [Top] [All Lists] |