| To: | Dave Chinner <david@xxxxxxxxxxxxx> |
|---|---|
| Subject: | Re: [PATCH 4/7] libxfs: don't discard dirty buffers |
| From: | Christoph Hellwig <hch@xxxxxxxxxxxxx> |
| Date: | Mon, 8 Feb 2016 01:03:11 -0800 |
| Cc: | xfs@xxxxxxxxxxx |
| Delivered-to: | xfs@xxxxxxxxxxx |
| In-reply-to: | <1454627108-19036-5-git-send-email-david@xxxxxxxxxxxxx> |
| References: | <1454627108-19036-1-git-send-email-david@xxxxxxxxxxxxx> <1454627108-19036-5-git-send-email-david@xxxxxxxxxxxxx> |
| User-agent: | Mutt/1.5.24 (2015-08-30) |
> - xfs_buf_t *bp = (xfs_buf_t *)node; > + struct xfs_buf *bp = (struct xfs_buf *)node; I'd much prefer to use container_of here (although it seems that currently only exists under the name list_entry in xfsprogs). But I guess that's better left for a later patch.. Otherwise looks fine, Reviewed-by: Christoph Hellwig <hch@xxxxxx> |
| Previous by Date: | Re: [PATCH 3/7] libxfs: directory node splitting does not have an extra block, Christoph Hellwig |
|---|---|
| Next by Date: | Re: [PATCH 5/7] libxfs: don't repeatedly shake unwritable buffers, Christoph Hellwig |
| Previous by Thread: | [PATCH 4/7] libxfs: don't discard dirty buffers, Dave Chinner |
| Next by Thread: | [PATCH 5/7] libxfs: don't repeatedly shake unwritable buffers, Dave Chinner |
| Indexes: | [Date] [Thread] [Top] [All Lists] |