Re: [PATCH] xfs: lock bitmap/summary inodes in xfs_rtbuf

xfs

Re: [PATCH] xfs: lock bitmap/summary inodes in xfs_rtbuf_get()

To:	Eric Sandeen <sandeen@xxxxxxxxxxx>
Subject:	Re: [PATCH] xfs: lock bitmap/summary inodes in xfs_rtbuf_get()
From:	Dave Chinner <david@xxxxxxxxxxxxx>
Date:	Tue, 2 Feb 2016 09:05:00 +1100
Cc:	Eric Sandeen <sandeen@xxxxxxxxxx>, xfs@xxxxxxxxxxx
Delivered-to:	xfs@xxxxxxxxxxx
In-reply-to:	<015F4CF0-425A-4EB0-ACE2-4EBBE0B78173@xxxxxxxxxxx>
References:	<56AC2D64.2080907@xxxxxxxxxx> <20160130210650.GL20456@dastard> <015F4CF0-425A-4EB0-ACE2-4EBBE0B78173@xxxxxxxxxxx>
User-agent:	Mutt/1.5.21 (2010-09-15)

On Sat, Jan 30, 2016 at 03:53:48PM -0600, Eric Sandeen wrote:
> OK, thanks Dave. It seemed like it was probably too simpleâ

Yeah, and the simple fix (lock in xfs_bmap_rtalloc()) uncovers
further issues w.r.t. logging - the buffers are not stamped with a
type, so log recovery will not categorise them correctly.

And, I suspect, log recovery might have problems with the
bitmap/smmary buffers as they don't have magic numbers in them. More
work to be done here...

Cheers,

Dave.
-- 
Dave Chinner
david@xxxxxxxxxxxxx

[More with this subject...]

<Prev in Thread]	Current Thread	[Next in Thread>
Re: [PATCH] xfs: lock bitmap/summary inodes in xfs_rtbuf_get(), Dave Chinner <=

Previous by Date:	Re: stop using ioends for direct write completions, Darrick J. Wong
Next by Date:	[PATCH 1/3] xfs: lock rt summary inode on allocation, Dave Chinner
Previous by Thread:	Re: stop using ioends for direct write completions, Darrick J. Wong
Next by Thread:	[PATCH 0/3] xfs: fix realtime device assert failures, Dave Chinner
Indexes:	[Date] [Thread] [Top] [All Lists]