xfs
[Top] [All Lists]

Re: stop using ioends for direct write completions

To: "Darrick J. Wong" <darrick.wong@xxxxxxxxxx>
Subject: Re: stop using ioends for direct write completions
From: Christoph Hellwig <hch@xxxxxx>
Date: Thu, 28 Jan 2016 23:02:55 +0100
Cc: xfs@xxxxxxxxxxx
Delivered-to: xfs@xxxxxxxxxxx
In-reply-to: <20160128215853.GC6431@xxxxxxxxxxxxxxxx>
References: <1452766237-2314-1-git-send-email-hch@xxxxxx> <20160128131656.GB14876@xxxxxxxxxxxxx> <20160128205333.GF20038@xxxxxxxxxxxxxxxx> <20160128211056.GA27287@xxxxxx> <20160128215853.GC6431@xxxxxxxxxxxxxxxx>
User-agent: Mutt/1.5.17 (2007-11-01)
On Thu, Jan 28, 2016 at 01:58:53PM -0800, Darrick J. Wong wrote:
> Aw, snap, I knew I'd forgotten something.  Yep, we'll need that... I think
> xfs_end_io_direct_write will have to sniff out the error status from "size"
> and either remap or discard the CoW allocations as appropriate.

I'd rather fix the direct I/O code to give us that information directly
(pun intended).  I'll add that to my short term todo list as it seems
useful for the existing code as well.

<Prev in Thread] Current Thread [Next in Thread>