| To: | Christoph Hellwig <hch@xxxxxxxxxxxxx> |
|---|---|
| Subject: | Re: stop using ioends for direct write completions |
| From: | "Darrick J. Wong" <darrick.wong@xxxxxxxxxx> |
| Date: | Thu, 28 Jan 2016 12:53:33 -0800 |
| Cc: | Christoph Hellwig <hch@xxxxxx>, xfs@xxxxxxxxxxx |
| Delivered-to: | xfs@xxxxxxxxxxx |
| In-reply-to: | <20160128131656.GB14876@xxxxxxxxxxxxx> |
| References: | <1452766237-2314-1-git-send-email-hch@xxxxxx> <20160128131656.GB14876@xxxxxxxxxxxxx> |
| User-agent: | Mutt/1.5.21 (2010-09-15) |
On Thu, Jan 28, 2016 at 05:16:56AM -0800, Christoph Hellwig wrote: > Any chance to get a review for this? It should really help > with sorting out the buffered I/O COW code. It looks reasonable to me. I separated the dio and buffered CoW remap paths a couple of weeks ago, because it seems that IO errors only get passed back as a return value from __blockdev_direct_IO, therefore the remapping has to be done from xfs_vm_do_dio anyway because we don't want to remap if the write fails. Just yesterday I removed the "is_cow" flag from the ioend, so now we're back to having a separate XFS_IO_COW ioend type. So... reflink doesn't need the patch but OTOH directio doesn't really need the overhead of allocating an ioend anyway. :) --D > > _______________________________________________ > xfs mailing list > xfs@xxxxxxxxxxx > http://oss.sgi.com/mailman/listinfo/xfs |
| <Prev in Thread] | Current Thread | [Next in Thread> |
|---|---|---|
| ||
| Previous by Date: | Re: [PATCH 1/4] xfstests: fix scratch device filtering in 139, Darrick J. Wong |
|---|---|
| Next by Date: | Re: a couple xfstests fixes for reflinks, Darrick J. Wong |
| Previous by Thread: | Re: stop using ioends for direct write completions, Christoph Hellwig |
| Next by Thread: | Re: stop using ioends for direct write completions, Christoph Hellwig |
| Indexes: | [Date] [Thread] [Top] [All Lists] |