xfs
[Top] [All Lists]

[PATCH] xfs: fix endianness error when checking log block crc on big end

To: Dave Chinner <david@xxxxxxxxxxxxx>
Subject: [PATCH] xfs: fix endianness error when checking log block crc on big endian platforms
From: "Darrick J. Wong" <darrick.wong@xxxxxxxxxx>
Date: Tue, 26 Jan 2016 10:05:00 -0800
Cc: xfs <xfs@xxxxxxxxxxx>, Eric Sandeen <sandeen@xxxxxxxxxx>, Brian Foster <bfoster@xxxxxxxxxx>
Delivered-to: xfs@xxxxxxxxxxx
User-agent: Mutt/1.5.21 (2010-09-15)
Since the checksum function and the field are both __le32, don't
perform endian conversion when comparing the two.  This fixes mount
failures on ppc64 in 4.5-rc1.

Signed-off-by: Darrick J. Wong <darrick.wong@xxxxxxxxxx>
---
 fs/xfs/xfs_log_recover.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/fs/xfs/xfs_log_recover.c b/fs/xfs/xfs_log_recover.c
index ac80f39..52dd946 100644
--- a/fs/xfs/xfs_log_recover.c
+++ b/fs/xfs/xfs_log_recover.c
@@ -4502,7 +4502,7 @@ xlog_recover_process(
         * know precisely what failed.
         */
        if (pass == XLOG_RECOVER_CRCPASS) {
-               if (rhead->h_crc && crc != le32_to_cpu(rhead->h_crc))
+               if (rhead->h_crc && crc != rhead->h_crc)
                        return -EFSBADCRC;
                return 0;
        }

<Prev in Thread] Current Thread [Next in Thread>