xfs
[Top] [All Lists]

Re: [PATCH] xfs_repair: Fix untranslatable strings

To: Eric Sandeen <sandeen@xxxxxxxxxxx>
Subject: Re: [PATCH] xfs_repair: Fix untranslatable strings
From: Christoph Hellwig <hch@xxxxxxxxxxxxx>
Date: Tue, 26 Jan 2016 08:47:00 -0800
Cc: xfs@xxxxxxxxxxx
Delivered-to: xfs@xxxxxxxxxxx
In-reply-to: <56A50508.4060207@xxxxxxxxxxx>
References: <20160124155853.GA10063@xxxxxxxxxxxxxxxxxx> <56A50508.4060207@xxxxxxxxxxx>
User-agent: Mutt/1.5.24 (2015-08-30)
On Sun, Jan 24, 2016 at 11:08:24AM -0600, Eric Sandeen wrote:
> Don't substitute in "would" or "will" for %s here, it makes
> it untranslatable.  Just spell it out twice like every other
> message in the function.
> 
> Reported-by: Jakub Bogusz <qboosh@xxxxxxxxxxxxx>
> Signed-off-by: Eric Sandeen <sandeen@xxxxxxxxxxx>

Looks good,

Reviewed-by: Christoph Hellwig <hch@xxxxxx>

<Prev in Thread] Current Thread [Next in Thread>