xfs
[Top] [All Lists]

Re: [PATCH 1/5] xfs_io: detect the '-R' option in getopt

To: Eric Sandeen <sandeen@xxxxxxxxxxx>
Subject: Re: [PATCH 1/5] xfs_io: detect the '-R' option in getopt
From: "Darrick J. Wong" <darrick.wong@xxxxxxxxxx>
Date: Fri, 22 Jan 2016 22:18:11 -0800
Cc: xfs@xxxxxxxxxxx
Delivered-to: xfs@xxxxxxxxxxx
In-reply-to: <56A307D8.60202@xxxxxxxxxxx>
References: <20160123003502.2475.99558.stgit@xxxxxxxxxxxxxxxx> <56A307D8.60202@xxxxxxxxxxx>
User-agent: Mutt/1.5.21 (2010-09-15)
On Fri, Jan 22, 2016 at 10:55:52PM -0600, Eric Sandeen wrote:
> On 1/22/16 6:35 PM, Darrick J. Wong wrote:
> > Configure getopt to accept the -R argument to pwrite.
> 
> Did you have anything against "F" and "B"? :)
> 
> (They're missing too but in the case statements & help)

No, but I /was/ wondering if the omission was deliberate?

--D

> 
> -Eric
> 
> > Signed-off-by: Darrick J. Wong <darrick.wong@xxxxxxxxxx>
> > ---
> >  io/pwrite.c |    2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> > 
> > 
> > diff --git a/io/pwrite.c b/io/pwrite.c
> > index fd9114d..c6efee9 100644
> > --- a/io/pwrite.c
> > +++ b/io/pwrite.c
> > @@ -259,7 +259,7 @@ pwrite_f(
> >     init_cvtnum(&fsblocksize, &fssectsize);
> >     bsize = fsblocksize;
> >  
> > -   while ((c = getopt(argc, argv, "b:Cdf:i:qs:S:uV:wWZ:")) != EOF) {
> > +   while ((c = getopt(argc, argv, "b:Cdf:i:qRs:S:uV:wWZ:")) != EOF) {
> >             switch (c) {
> >             case 'b':
> >                     tmp = cvtnum(fsblocksize, fssectsize, optarg);
> > 
> > _______________________________________________
> > xfs mailing list
> > xfs@xxxxxxxxxxx
> > http://oss.sgi.com/mailman/listinfo/xfs
> > 
> 
> _______________________________________________
> xfs mailing list
> xfs@xxxxxxxxxxx
> http://oss.sgi.com/mailman/listinfo/xfs

<Prev in Thread] Current Thread [Next in Thread>