xfs
[Top] [All Lists]

Re: [PATCH 0/4] quota: add new quotactl Q_XGETQUOTA2

To: Eric Sandeen <sandeen@xxxxxxxxxx>
Subject: Re: [PATCH 0/4] quota: add new quotactl Q_XGETQUOTA2
From: Christoph Hellwig <hch@xxxxxxxxxxxxx>
Date: Fri, 8 Jan 2016 23:26:00 -0800
Cc: fsdevel <linux-fsdevel@xxxxxxxxxxxxxxx>, xfs@xxxxxxxxxxx, Jan Kara <jack@xxxxxxx>
Delivered-to: xfs@xxxxxxxxxxx
In-reply-to: <568FEA2C.6080708@xxxxxxxxxx>
References: <568FEA2C.6080708@xxxxxxxxxx>
User-agent: Mutt/1.5.23 (2014-03-12)
On Fri, Jan 08, 2016 at 10:56:12AM -0600, Eric Sandeen wrote:
> This adds a new quotactl, Q_XGETQUOTA2.
> 
> Q_XGETQUOTA2 is exactly like Q_XGETQUOTA, except that it will
> return quota information for the id equal to or greater than
> the id requested.  In other words, if the specified id has
> no quota, the command will return quota information for the
> next higher id which does have a quota set.  If no higher id
> has an active quota, -ESRCH is returned.

Please add a flags argument to Q_XGETQUOTA2, and then make the
new behavior the first flag.  Keep Q_XGETQUOTA behavior for the
flag-less case.  That way we get future etensibility for free.

<Prev in Thread] Current Thread [Next in Thread>