| To: | "Darrick J. Wong" <darrick.wong@xxxxxxxxxx> |
|---|---|
| Subject: | Re: [PATCH 3/3] xfs: cancel COW in xfs_cancel_ioend |
| From: | Christoph Hellwig <hch@xxxxxx> |
| Date: | Thu, 7 Jan 2016 16:25:42 +0100 |
| Cc: | xfs@xxxxxxxxxxx |
| Delivered-to: | xfs@xxxxxxxxxxx |
| In-reply-to: | <20160107003227.GB8015@xxxxxxxxxxxxxxxx> |
| References: | <1451822873-12969-1-git-send-email-hch@xxxxxx> <1451822873-12969-4-git-send-email-hch@xxxxxx> <20160105014310.GK28330@xxxxxxxxxxxxxxxx> <20160105104214.GA16310@xxxxxxxxxxxxx> <20160107003227.GB8015@xxxxxxxxxxxxxxxx> |
| User-agent: | Mutt/1.5.17 (2007-11-01) |
On Wed, Jan 06, 2016 at 04:32:27PM -0800, Darrick J. Wong wrote: > Ok. I spent a couple of days trying to find all the places where we need to > delete CoW reservations (hole punch, truncate, etc.) and found some places > where the code was leaving reservations behind in the CoW fork (most notable > truncate). I also made the inode eviction code purge any CoW leftovers, so > that should all go away. Can you send that part out for NFS testing? > I also wrote some more xfstests that try to hit all the CoW-cancelling code > paths (fpunch, fzero, fcollapse, finsert, truncate, -EIO) to smoke test all > that. By the way, do you have a testcase handy for the "non-blocking > writeback > EAGAIN" case? I'm guessing that we could hit that pretty easily by lowering > dirty_background_* and dirtying a lot of pages while reflinking? I did hit it pretty easily testing over NFS to a local nfs server with xfstests. |
| <Prev in Thread] | Current Thread | [Next in Thread> |
|---|---|---|
| ||
| Previous by Date: | Re: [PATCH v7 1/9] dax: fix NULL pointer dereference in __dax_dbg(), Dan Williams |
|---|---|
| Next by Date: | Re: [PATCH v7 2/9] dax: fix conversion of holes to PMDs, Ross Zwisler |
| Previous by Thread: | Re: [PATCH 3/3] xfs: cancel COW in xfs_cancel_ioend, Darrick J. Wong |
| Next by Thread: | Re: [PATCH 3/3] xfs: cancel COW in xfs_cancel_ioend, Darrick J. Wong |
| Indexes: | [Date] [Thread] [Top] [All Lists] |