Re: [PATCH V4] xfs: eliminate committed arg from xfs_bmap

xfs

Re: [PATCH V4] xfs: eliminate committed arg from xfs_bmap_finish

To:	Eric Sandeen <sandeen@xxxxxxxxxxx>
Subject:	Re: [PATCH V4] xfs: eliminate committed arg from xfs_bmap_finish
From:	Christoph Hellwig <hch@xxxxxxxxxxxxx>
Date:	Tue, 5 Jan 2016 21:31:23 -0800
Cc:	xfs@xxxxxxxxxxx
Delivered-to:	xfs@xxxxxxxxxxx
In-reply-to:	<568C917C.9050509@xxxxxxxxxxx>
References:	<56441B8E.6070603@xxxxxxxxxx> <5644BEF8.6070201@xxxxxxxxxxx> <568C131C.9080907@xxxxxxxxxxx> <568C917C.9050509@xxxxxxxxxxx>
User-agent:	Mutt/1.5.23 (2014-03-12)

Looks great!

Reviewed-by: Christoph Hellwig <hch@xxxxxx>

Note that the "if (*tpp != tp)" trick also works in xfs_bmap_finish, which
will allows us to fold __xfs_trans_roll into xfs_trans_roll in a follow
on patch.

[More with this subject...]

<Prev in Thread]	Current Thread	[Next in Thread>
[PATCH V3] xfs: eliminate committed arg from xfs_bmap_finish, Eric Sandeen Re: [PATCH V3] xfs: eliminate committed arg from xfs_bmap_finish, Dave Chinner [PATCH V4] xfs: eliminate committed arg from xfs_bmap_finish, Eric Sandeen Re: [PATCH V4] xfs: eliminate committed arg from xfs_bmap_finish, Christoph Hellwig <=

Previous by Date:	[PATCH v2 4/4] block, xfs: implement 'force_failure' notifications, Dan Williams
Next by Date:	Re: [PATCH] xfs: handle dquot buffer readahead in log recovery correctly, Brian Foster
Previous by Thread:	[PATCH V4] xfs: eliminate committed arg from xfs_bmap_finish, Eric Sandeen
Next by Thread:	[PATCH 00/35 v2] separate operations from flags in the bio/request structs, mchristi
Indexes:	[Date] [Thread] [Top] [All Lists]