xfs
[Top] [All Lists]

Re: [PATCH 02/76] xfs: fix log ticket type printing

To: Dave Chinner <david@xxxxxxxxxxxxx>
Subject: Re: [PATCH 02/76] xfs: fix log ticket type printing
From: "Darrick J. Wong" <darrick.wong@xxxxxxxxxx>
Date: Mon, 4 Jan 2016 11:57:48 -0800
Cc: Christoph Hellwig <hch@xxxxxxxxxxxxx>, xfs@xxxxxxxxxxx
Delivered-to: xfs@xxxxxxxxxxx
In-reply-to: <20160103212905.GY19802@dastard>
References: <20151219085622.12713.88678.stgit@xxxxxxxxxxxxxxxx> <20151219085636.12713.59155.stgit@xxxxxxxxxxxxxxxx> <20160103121353.GA28429@xxxxxxxxxxxxx> <20160103212905.GY19802@dastard>
User-agent: Mutt/1.5.21 (2010-09-15)
On Mon, Jan 04, 2016 at 08:29:05AM +1100, Dave Chinner wrote:
> On Sun, Jan 03, 2016 at 04:13:53AM -0800, Christoph Hellwig wrote:
> > On Sat, Dec 19, 2015 at 12:56:36AM -0800, Darrick J. Wong wrote:
> > > Update the log ticket reservation type printing code to reflect
> > > all the types of log tickets, to avoid incorrect debug output and
> > > avoid running off the end of the array.
> > 
> > This looks okay, but I think we should use name array initializers
> > to make sure it doesn't got out of sync ever.
> 
> Good idea, separate patch is fine.

Will do.

--D

> 
> Cheers,
> 
> Dave.
> -- 
> Dave Chinner
> david@xxxxxxxxxxxxx

<Prev in Thread] Current Thread [Next in Thread>