| To: | Christoph Hellwig <hch@xxxxxxxxxxxxx> |
|---|---|
| Subject: | Re: [PATCH 02/76] xfs: fix log ticket type printing |
| From: | Dave Chinner <david@xxxxxxxxxxxxx> |
| Date: | Mon, 4 Jan 2016 08:29:05 +1100 |
| Cc: | "Darrick J. Wong" <darrick.wong@xxxxxxxxxx>, xfs@xxxxxxxxxxx |
| Delivered-to: | xfs@xxxxxxxxxxx |
| In-reply-to: | <20160103121353.GA28429@xxxxxxxxxxxxx> |
| References: | <20151219085622.12713.88678.stgit@xxxxxxxxxxxxxxxx> <20151219085636.12713.59155.stgit@xxxxxxxxxxxxxxxx> <20160103121353.GA28429@xxxxxxxxxxxxx> |
| User-agent: | Mutt/1.5.21 (2010-09-15) |
On Sun, Jan 03, 2016 at 04:13:53AM -0800, Christoph Hellwig wrote: > On Sat, Dec 19, 2015 at 12:56:36AM -0800, Darrick J. Wong wrote: > > Update the log ticket reservation type printing code to reflect > > all the types of log tickets, to avoid incorrect debug output and > > avoid running off the end of the array. > > This looks okay, but I think we should use name array initializers > to make sure it doesn't got out of sync ever. Good idea, separate patch is fine. Cheers, Dave. -- Dave Chinner david@xxxxxxxxxxxxx |
| <Prev in Thread] | Current Thread | [Next in Thread> |
|---|---|---|
| ||
| Previous by Date: | Re: [PATCH 2/3] xfs: handle shutdown notifications, Dave Chinner |
|---|---|
| Next by Date: | Re: [PATCH 35/76] libxfs: refactor short btree block verification, Dave Chinner |
| Previous by Thread: | Re: [PATCH 02/76] xfs: fix log ticket type printing, Christoph Hellwig |
| Next by Thread: | Re: [PATCH 02/76] xfs: fix log ticket type printing, Darrick J. Wong |
| Indexes: | [Date] [Thread] [Top] [All Lists] |