| To: | "Darrick J. Wong" <darrick.wong@xxxxxxxxxx> |
|---|---|
| Subject: | Re: [PATCH 05/76] libxfs: pack the agfl header structure so XFS_AGFL_SIZE is correct |
| From: | Christoph Hellwig <hch@xxxxxxxxxxxxx> |
| Date: | Sun, 3 Jan 2016 04:15:25 -0800 |
| Cc: | david@xxxxxxxxxxxxx, xfs@xxxxxxxxxxx |
| Delivered-to: | xfs@xxxxxxxxxxx |
| In-reply-to: | <20151219085655.12713.60317.stgit@xxxxxxxxxxxxxxxx> |
| References: | <20151219085622.12713.88678.stgit@xxxxxxxxxxxxxxxx> <20151219085655.12713.60317.stgit@xxxxxxxxxxxxxxxx> |
| User-agent: | Mutt/1.5.23 (2014-03-12) |
On Sat, Dec 19, 2015 at 12:56:55AM -0800, Darrick J. Wong wrote: > Because struct xfs_agfl is 36 bytes long and has a 64-bit integer > inside it, gcc will quietly round the structure size up to the nearest > 64 bits -- in this case, 40 bytes. This results in the XFS_AGFL_SIZE > macro returning incorrect results for v5 filesystems on 64-bit > machines (118 items instead of 119). As a result, a 32-bit xfs_repair > will see garbage in AGFL item 119 and complain. > > Therefore, tell gcc not to pad the structure so that the AGFL size > calculation is correct. Do you have a testcase for this? |
| <Prev in Thread] | Current Thread | [Next in Thread> |
|---|---|---|
| ||
| Previous by Date: | Re: [PATCH 02/76] xfs: fix log ticket type printing, Christoph Hellwig |
|---|---|
| Next by Date: | Re: [PATCH 34/76] xfs: implement XFS_IOC_SWAPEXT when rmap btree is enabled, Christoph Hellwig |
| Previous by Thread: | Re: [PATCH 02/76] xfs: fix log ticket type printing, Christoph Hellwig |
| Next by Thread: | Re: [PATCH 05/76] libxfs: pack the agfl header structure so XFS_AGFL_SIZE is correct, Darrick J. Wong |
| Indexes: | [Date] [Thread] [Top] [All Lists] |