| To: | Vivek Trivedi <t.vivek@xxxxxxxxxxx> |
|---|---|
| Subject: | Re: [PATCH v2 3/4] xfsprogs: mkfs: fix unintentional integer overflow |
| From: | Christoph Hellwig <hch@xxxxxxxxxxxxx> |
| Date: | Sun, 20 Dec 2015 07:36:49 -0800 |
| Cc: | xfs@xxxxxxxxxxx, a.sahrawat@xxxxxxxxxxx, pankaj.m@xxxxxxxxxxx |
| Delivered-to: | xfs@xxxxxxxxxxx |
| In-reply-to: | <1449832143-26356-4-git-send-email-t.vivek@xxxxxxxxxxx> |
| References: | <1449832143-26356-1-git-send-email-t.vivek@xxxxxxxxxxx> <1449832143-26356-4-git-send-email-t.vivek@xxxxxxxxxxx> |
| User-agent: | Mutt/1.5.23 (2014-03-12) |
> +++ b/mkfs/xfs_mkfs.c
> @@ -2022,7 +2022,7 @@ _("warning: sparse inodes not supported without CRC
> support, disabled.\n"));
> * and the underlying volume is striped, then set rtextblocks
> * to the stripe width.
> */
> - int rswidth;
> + __uint64_t rswidth;
> __uint64_t rtextbytes;
This looks odd. We initiallize assigned ft.rtswidth (which is an int)
or 0 to it. I think you want a separate variable for the result of
the DTOBT(rswidth) statement to make this clear.
|
| <Prev in Thread] | Current Thread | [Next in Thread> |
|---|---|---|
| ||
| Previous by Date: | Re: [PATCH v2 2/4] xfsprogs: fix integer overflow in xlog_find_verify_cycle, Christoph Hellwig |
|---|---|
| Next by Date: | Re: [PATCH v2 4/4] xfsprogs: xfsdb: remove unnessary checks in process_leaf_node_dir_v2_free, Christoph Hellwig |
| Previous by Thread: | [PATCH v2 3/4] xfsprogs: mkfs: fix unintentional integer overflow, Vivek Trivedi |
| Next by Thread: | Re: [PATCH v2 3/4] xfsprogs: mkfs: fix unintentional integer overflow, Dave Chinner |
| Indexes: | [Date] [Thread] [Top] [All Lists] |