Re: [PATCH 07/11] xfsprogs: xfs_fsr: replace sprintf with snprintf to av

To:	Eric Sandeen <sandeen@xxxxxxxxxxx>
Subject:	Re: [PATCH 07/11] xfsprogs: xfs_fsr: replace sprintf with snprintf to avoid buffer overflow
From:	Dave Chinner <david@xxxxxxxxxxxxx>
Date:	Thu, 3 Dec 2015 17:07:01 +1100
Cc:	xfs@xxxxxxxxxxx
Delivered-to:	xfs@xxxxxxxxxxx
In-reply-to:	<565FD6A2.9040406@xxxxxxxxxxx>
References:	<1449055167-19936-1-git-send-email-t.vivek@xxxxxxxxxxx> <1449055167-19936-8-git-send-email-t.vivek@xxxxxxxxxxx> <565FD6A2.9040406@xxxxxxxxxxx>
User-agent:	Mutt/1.5.21 (2010-09-15)

On Wed, Dec 02, 2015 at 11:44:02PM -0600, Eric Sandeen wrote:
> 
> it seems like the sprintfs in i.e. fsrall_cleanup() and tmp_init()
> might have the same problem, no?
> 
> And then what happens if it is truncated to SMBUFSZ; at that point
> I think this needs error handling, if the string got truncated.

Might be easier to simply increase the size of SMBUFSZ so that
overrun is not possible?

-Dave
-- 
Dave Chinner
david@xxxxxxxxxxxxx

<Prev in Thread]	Current Thread	[Next in Thread>
Re: [PATCH 02/11] xfsprogs: fix integer overflow in xlog_find_verify_cycle, (continued) Re: [PATCH 02/11] xfsprogs: fix integer overflow in xlog_find_verify_cycle, Dave Chinner [PATCH 01/11] xfsprogs: xfs_io: fix a memory leak in imap_f, Vivek Trivedi Re: [PATCH 01/11] xfsprogs: xfs_io: fix a memory leak in imap_f, Eric Sandeen [PATCH 03/11] xfsprogs: mkfs: fix unintentional integer overflow, Vivek Trivedi Re: [PATCH 03/11] xfsprogs: mkfs: fix unintentional integer overflow, Eric Sandeen Re: [PATCH 03/11] xfsprogs: mkfs: fix unintentional integer overflow, Dave Chinner [PATCH 08/11] xfsprogs: xfs_repair: fix possible null dereference in build_ino_tree, Vivek Trivedi Re: [PATCH 08/11] xfsprogs: xfs_repair: fix possible null dereference in build_ino_tree, Dave Chinner [PATCH 07/11] xfsprogs: xfs_fsr: replace sprintf with snprintf to avoid buffer overflow, Vivek Trivedi Re: [PATCH 07/11] xfsprogs: xfs_fsr: replace sprintf with snprintf to avoid buffer overflow, Eric Sandeen Re: [PATCH 07/11] xfsprogs: xfs_fsr: replace sprintf with snprintf to avoid buffer overflow, Dave Chinner <= [PATCH 05/11] xfsprogs: xfs_mdrestore: check bad read count in perform_restore, Vivek Trivedi Re: [PATCH 05/11] xfsprogs: xfs_mdrestore: check bad read count in perform_restore, Eric Sandeen Re: [PATCH 05/11] xfsprogs: xfs_mdrestore: check bad read count in perform_restore, Dave Chinner Re: [PATCH 05/11] xfsprogs: xfs_mdrestore: check bad read count in perform_restore, Eric Sandeen [PATCH 06/11] xfsprogs: xfs_db: check null derefernce after block_to_bt, Vivek Trivedi Re: [PATCH 06/11] xfsprogs: xfs_db: check null derefernce after block_to_bt, Eric Sandeen [PATCH 10/11] xfsprogs: fix possible null pointer dereference in xfs_iformat_extents, Vivek Trivedi Re: [PATCH 10/11] xfsprogs: fix possible null pointer dereference in xfs_iformat_extents, Dave Chinner [PATCH 11/11] xfsprogs: xfs_repair: fix possible null pointer dereference in mark_standalone_inodes, Vivek Trivedi Re: [PATCH 11/11] xfsprogs: xfs_repair: fix possible null pointer dereference in mark_standalone_inodes, Dave Chinner

Previous by Date:	Re: [PATCH 05/11] xfsprogs: xfs_mdrestore: check bad read count in perform_restore, Eric Sandeen
Next by Date:	Re: [PATCH 08/11] xfsprogs: xfs_repair: fix possible null dereference in build_ino_tree, Dave Chinner
Previous by Thread:	Re: [PATCH 07/11] xfsprogs: xfs_fsr: replace sprintf with snprintf to avoid buffer overflow, Eric Sandeen
Next by Thread:	[PATCH 05/11] xfsprogs: xfs_mdrestore: check bad read count in perform_restore, Vivek Trivedi
Indexes:	[Date] [Thread] [Top] [All Lists]