| To: | Al Viro <viro@xxxxxxxxxxxxxxxxxx> |
|---|---|
| Subject: | Re: clone ioctl return values |
| From: | Christoph Hellwig <hch@xxxxxxxxxxxxx> |
| Date: | Tue, 17 Nov 2015 07:36:23 -0800 |
| Cc: | linux-fsdevel@xxxxxxxxxxxxxxx, Chris Mason <clm@xxxxxx>, xfs@xxxxxxxxxxx, "Darrick J. Wong" <darrick.wong@xxxxxxxxxx> |
| Delivered-to: | xfs@xxxxxxxxxxx |
| In-reply-to: | <20151117153320.GU22011@xxxxxxxxxxxxxxxxxx> |
| References: | <20151116120431.GA2860@xxxxxxxxxxxxx> <20151117002822.GA32467@xxxxxxxxxxxxxxxx> <20151117105433.GA18093@xxxxxxxxxxxxx> <20151117135745.GF17545@xxxxxxxxxxxxxxxxxxx> <20151117152251.GA5392@xxxxxxxxxxxxx> <20151117153320.GU22011@xxxxxxxxxxxxxxxxxx> |
| User-agent: | Mutt/1.5.23 (2014-03-12) |
On Tue, Nov 17, 2015 at 03:33:20PM +0000, Al Viro wrote: > On Tue, Nov 17, 2015 at 07:22:52AM -0800, Christoph Hellwig wrote: > > > Yes, I saw that. So so far I'd suggest something like the following > > for btrfs: > > > > - return EBADFD for missing read/wite permissions > > Yowwwch... What the hell does that have to do with STREAMS? Or are you > using EBADFD as "nobody uses that error value anyway, let's assign it > whatever meaning we need"? > > Besides, that'll be confused with EBADF all the time. I strongly > recommend against that. Yes, I meant EBADF. That's what we normally use for missing FMODE_READ/WRITE or fget failures, so why would this call be different from everything else? |
| <Prev in Thread] | Current Thread | [Next in Thread> |
|---|---|---|
| ||
| Previous by Date: | Re: clone ioctl return values, Al Viro |
|---|---|
| Next by Date: | Re: Disk error, then endless loop, Chris Dunlop |
| Previous by Thread: | Re: clone ioctl return values, Al Viro |
| Next by Thread: | Re: clone ioctl return values, Chris Mason |
| Indexes: | [Date] [Thread] [Top] [All Lists] |