Re: [RFCv3.1 00/11] xfstests: test the nfs/cifs/btrfs/xfs reflink/dedupe

To:	"Darrick J. Wong" <darrick.wong@xxxxxxxxxx>
Subject:	Re: [RFCv3.1 00/11] xfstests: test the nfs/cifs/btrfs/xfs reflink/dedupe ioctls
From:	Christoph Hellwig <hch@xxxxxxxxxxxxx>
Date:	Thu, 12 Nov 2015 04:51:15 -0800
Cc:	david@xxxxxxxxxxxxx, fstests@xxxxxxxxxxxxxxx, xfs@xxxxxxxxxxx, tao.peng@xxxxxxxxxxxxxxx, linux-ext4@xxxxxxxxxxxxxxx, Anna.Schumaker@xxxxxxxxxx, linux-btrfs@xxxxxxxxxxxxxxx
Delivered-to:	xfs@xxxxxxxxxxx
In-reply-to:	<20151112090756.GA25685@xxxxxxxxxxxxx>
References:	<20151111192628.15056.6451.stgit@xxxxxxxxxxxxxxxx> <20151112090756.GA25685@xxxxxxxxxxxxx>
User-agent:	Mutt/1.5.23 (2014-03-12)

On Thu, Nov 12, 2015 at 01:07:56AM -0800, Christoph Hellwig wrote:
> Looks fine:
> 
> Acked-by: Christoph Hellwig <hch@xxxxxx>

Actually I take this back.  I had though this was the existing series
with my fixes, but this one still incorrectly assumes that if reflink
works dedup works as well, leading to lots of false failures on nfs.

<Prev in Thread]	Current Thread	[Next in Thread>
[PATCH 03/11] reflink: basic tests of the reflink and dedupe ioctls, (continued) [PATCH 03/11] reflink: basic tests of the reflink and dedupe ioctls, Darrick J. Wong [PATCH 04/11] reflink: test CoW behaviors of reflinked files, Darrick J. Wong [PATCH 05/11] reflink: test the various fallocate modes, Darrick J. Wong [PATCH 06/11] reflink: concurrent operations tests, Darrick J. Wong [PATCH 07/11] reflink: test accuracy of free block counts, Darrick J. Wong [PATCH 08/11] reflink: test error conditions due to bad inputs, Darrick J. Wong [PATCH 10/11] reflink: test what happens when we hit resource limits, Darrick J. Wong [PATCH 09/11] xfs: test xfs-specific reflink pieces, Darrick J. Wong [PATCH 11/11] reflink: test that CoW writes fail when we're out of space, Darrick J. Wong Re: [RFCv3.1 00/11] xfstests: test the nfs/cifs/btrfs/xfs reflink/dedupe ioctls, Christoph Hellwig Re: [RFCv3.1 00/11] xfstests: test the nfs/cifs/btrfs/xfs reflink/dedupe ioctls, Christoph Hellwig <= Re: [RFCv3.1 00/11] xfstests: test the nfs/cifs/btrfs/xfs reflink/dedupe ioctls, Darrick J. Wong Re: [RFCv3.1 00/11] xfstests: test the nfs/cifs/btrfs/xfs reflink/dedupe ioctls, Christoph Hellwig Re: [RFCv3.1 00/11] xfstests: test the nfs/cifs/btrfs/xfs reflink/dedupe ioctls, Darrick J. Wong Re: [RFCv3.1 00/11] xfstests: test the nfs/cifs/btrfs/xfs reflink/dedupe ioctls, Christoph Hellwig Re: [RFCv3.1 00/11] xfstests: test the nfs/cifs/btrfs/xfs reflink/dedupe ioctls, Darrick J. Wong

Previous by Date:	Re: [PATCH] xfs: print name of verifier if it fails, Brian Foster
Next by Date:	Re: xfsprogs install, Emmanuel Florac
Previous by Thread:	Re: [RFCv3.1 00/11] xfstests: test the nfs/cifs/btrfs/xfs reflink/dedupe ioctls, Christoph Hellwig
Next by Thread:	Re: [RFCv3.1 00/11] xfstests: test the nfs/cifs/btrfs/xfs reflink/dedupe ioctls, Darrick J. Wong
Indexes:	[Date] [Thread] [Top] [All Lists]