| To: | Dave Chinner <david@xxxxxxxxxxxxx>, <xfs@xxxxxxxxxxx>, Tejun Heo <htejun@xxxxxx> |
|---|---|
| Subject: | Re: [PATCH RFC] use WQ_MEM_RECLAIM for m_log_workqueue |
| From: | Chris Mason <clm@xxxxxx> |
| Date: | Thu, 5 Nov 2015 07:10:59 -0500 |
| Delivered-to: | xfs@xxxxxxxxxxx |
| Dkim-signature: | v=1; a=rsa-sha256; c=relaxed/simple; d=fb.com; h=date : from : to : subject : message-id : references : mime-version : content-type : in-reply-to; s=facebook; bh=SLsRcS4J6G2CkgjiwFaI5ra63JeJEZqwvhmcJGmY7MY=; b=QXr+rh8LgWbVaJahrddHt2ACI8q01zJsyo1brTWg3GzWz3rdigzZvaRJzEO6b5Q1If0x rROrx4SY+PjJsY5Rpn9RWFzdxwF2XvvwR1scESgug7heKmn62W9W5SASf+IeigmTYO9Y Yze74nMGlDs4zpbkIaSSEVkGTVcwotkWFL0= |
| In-reply-to: | <20151104185103.GC5458@xxxxxxxxxxxxxxxxxxx> |
| References: | <20151104185103.GC5458@xxxxxxxxxxxxxxxxxxx> |
| User-agent: | Mutt/1.5.23.1 (2014-03-12) |
On Wed, Nov 04, 2015 at 01:51:03PM -0500, Chris Mason wrote: > I think we should be using WQ_MEM_RECLAIM to make sure this thread pool > makes progress when we're not able to allocate new workers. Thinking harder, it's probably best to just flag them all WQ_MEM_RECLAIM. This is what btrfs does, and it saves you from painful discoveries about how different queues depend on each other. Tejun did verify in the dump that progress on m_log_workqueue was stuck waiting for more threads. I'll start testing and send a v2. -chris |
| <Prev in Thread] | Current Thread | [Next in Thread> |
|---|---|---|
| ||
| Previous by Date: | [PATCH v14 22/22] ext4: Add richacl feature flag, Andreas Gruenbacher |
|---|---|
| Next by Date: | Re: [PATCH v13 45/51] sunrpc: Allow to demand-allocate pages to encode into, Trond Myklebust |
| Previous by Thread: | [PATCH RFC] use WQ_MEM_RECLAIM for m_log_workqueue, Chris Mason |
| Next by Thread: | Re: [PATCH RFC] use WQ_MEM_RECLAIM for m_log_workqueue, Dave Chinner |
| Indexes: | [Date] [Thread] [Top] [All Lists] |