xfs
[Top] [All Lists]

Re: [PATCH 2/2] xfs: invalidate cached acl if set via ioctl

To: Andreas Gruenbacher <agruenba@xxxxxxxxxx>
Subject: Re: [PATCH 2/2] xfs: invalidate cached acl if set via ioctl
From: Dave Chinner <david@xxxxxxxxxxxxx>
Date: Tue, 3 Nov 2015 13:12:32 +1100
Cc: Brian Foster <bfoster@xxxxxxxxxx>, xfs@xxxxxxxxxxx
Delivered-to: xfs@xxxxxxxxxxx
In-reply-to: <1446493974-24669-3-git-send-email-agruenba@xxxxxxxxxx>
References: <1446217508-22157-1-git-send-email-agruenba@xxxxxxxxxx> <20151102025352.GY19199@dastard> <1446493974-24669-3-git-send-email-agruenba@xxxxxxxxxx>
User-agent: Mutt/1.5.21 (2010-09-15)
On Mon, Nov 02, 2015 at 08:52:54PM +0100, Andreas Gruenbacher wrote:
> Setting or removing the "SGI_ACL_[FILE|DEFAULT]" attributes via the
> XFS_IOC_ATTRMULTI_BY_HANDLE ioctl completely bypasses the POSIX ACL
> infrastructure, like setting the "trusted.SGI_ACL_[FILE|DEFAULT]" xattrs
> did until commit 6caa1056.  Similar to that commit, invalidate cached
> acls when setting/removing them via the ioctl as well.
> 
> Signed-off-by: Andreas Gruenbacher <agruenba@xxxxxxxxxx>

Thanks, Andreas. I've pulled the fixes in. I updated the original
patch with the fix in patch 1, and applied this patch. I'll push out
a rebased for-next branch after some further testing...

Cheers,

Dave.
-- 
Dave Chinner
david@xxxxxxxxxxxxx

<Prev in Thread] Current Thread [Next in Thread>