xfs
[Top] [All Lists]

Re: [PATCH] headers: remove definition of ASSERT from xfs.h

To: Dave Chinner <david@xxxxxxxxxxxxx>
Subject: Re: [PATCH] headers: remove definition of ASSERT from xfs.h
From: Christoph Hellwig <hch@xxxxxxxxxxxxx>
Date: Thu, 15 Oct 2015 22:35:04 -0700
Cc: xfs@xxxxxxxxxxx
Delivered-to: xfs@xxxxxxxxxxx
In-reply-to: <1444952814-13063-1-git-send-email-david@xxxxxxxxxxxxx>
References: <1444952814-13063-1-git-send-email-david@xxxxxxxxxxxxx>
User-agent: Mutt/1.5.23 (2014-03-12)
On Fri, Oct 16, 2015 at 10:46:54AM +1100, Dave Chinner wrote:
> From: Dave Chinner <dchinner@xxxxxxxxxx>
> 
> If we define ASSERT() in the installed xfs.h header file, programs
> including this header file will have their local definitions of
> ASSERT screwed up. This is something internal to the xfsprogs build,
> so move it to platform_defs.h.in where it will no longer be public.
> 
> Signed-off-by: Dave Chinner <dchinner@xxxxxxxxxx>

Looks good,

Reviewed-by: Christoph Hellwig <hch@xxxxxx>

<Prev in Thread] Current Thread [Next in Thread>