| To: | Jan Tulak <jtulak@xxxxxxxxxx> |
|---|---|
| Subject: | Re: [PATCH 10/11] xfsprogs: add dummy mntent for OS X |
| From: | Dave Chinner <david@xxxxxxxxxxxxx> |
| Date: | Thu, 3 Sep 2015 20:33:17 +1000 |
| Cc: | Christoph Hellwig <hch@xxxxxxxxxxxxx>, xfs-oss <xfs@xxxxxxxxxxx> |
| Delivered-to: | xfs@xxxxxxxxxxx |
| In-reply-to: | <CACj3i73Px4Zxfyz1GMZN=4r_LeONPMwfLT=P7C7bNDDshJ1ipA@xxxxxxxxxxxxxx> |
| References: | <1440590449-20372-1-git-send-email-jtulak@xxxxxxxxxx> <1440590555-20463-1-git-send-email-jtulak@xxxxxxxxxx> <1440590555-20463-10-git-send-email-jtulak@xxxxxxxxxx> <20150831190120.GK349@xxxxxxxxxxxxx> <CACj3i73Px4Zxfyz1GMZN=4r_LeONPMwfLT=P7C7bNDDshJ1ipA@xxxxxxxxxxxxxx> |
| User-agent: | Mutt/1.5.21 (2010-09-15) |
On Thu, Sep 03, 2015 at 11:01:44AM +0200, Jan Tulak wrote: > On Mon, Aug 31, 2015 at 9:01 PM, Christoph Hellwig <hch@xxxxxxxxxxxxx> > wrote: > > > On Wed, Aug 26, 2015 at 02:02:34PM +0200, Jan Tulak wrote: > > > Because these calls are used only by xfs_fsr, which can't > > > work on OS X unless a way how to mount XFS is found, > > > there is not use in implementing these calls. > > > > Take a look at the quota code for the BSD alternative to mntent. > > That code should be moved into a common location and used by fsr. > > > > âI tried to find it, but didn't found... Could you point me where it is? > Quota/freebsd.h has just few lines with one definition with errno = > -ENOSYS, and in other files in quota/, I didn't saw anything BSD specific. I think Christoph is refering to the code in libxcmd/paths.c: #if defined(HAVE_GETMNTENT) .... #elif defined(HAVE_GETMNTINFO) .... #else # error "How do I extract info about mounted filesystems on this platform?" #endif # HAVE_GETMNTINFO is for BSD systems, IIRC. Cheers, Dave. -- Dave Chinner david@xxxxxxxxxxxxx |
| <Prev in Thread] | Current Thread | [Next in Thread> |
|---|---|---|
| ||
| Previous by Date: | [PATCH 02a/11] xfsprogs: Add XATTR_LIST_MAX to OS X headers, Jan Tulak |
|---|---|
| Next by Date: | [PATCH 02b/11] xfsprogs: avoid dependency on Linux XATTR_SIZE_MAX, Jan Tulak |
| Previous by Thread: | Re: [PATCH 10/11] xfsprogs: add dummy mntent for OS X, Jan Tulak |
| Next by Thread: | Re: [PATCH 10/11] xfsprogs: add dummy mntent for OS X, Jan Tulak |
| Indexes: | [Date] [Thread] [Top] [All Lists] |