xfs
[Top] [All Lists]

Re: [PATCH 02/11] xfsprogs: avoid dependency on linux XATTR_SIZE/LIST_MA

To: Jan Tulak <jtulak@xxxxxxxxxx>
Subject: Re: [PATCH 02/11] xfsprogs: avoid dependency on linux XATTR_SIZE/LIST_MAX
From: Christoph Hellwig <hch@xxxxxxxxxxxxx>
Date: Mon, 31 Aug 2015 11:58:17 -0700
Cc: xfs@xxxxxxxxxxx, hch@xxxxxxxxxxxxx
Delivered-to: xfs@xxxxxxxxxxx
In-reply-to: <1440590555-20463-2-git-send-email-jtulak@xxxxxxxxxx>
References: <1440590449-20372-1-git-send-email-jtulak@xxxxxxxxxx> <1440590555-20463-1-git-send-email-jtulak@xxxxxxxxxx> <1440590555-20463-2-git-send-email-jtulak@xxxxxxxxxx>
User-agent: Mutt/1.5.23 (2014-03-12)
> index b1c0c10..d532f44 100644
> --- a/libhandle/handle.c
> +++ b/libhandle/handle.c
> @@ -21,6 +21,8 @@
>  #include "xfs.h"
>  #include "handle.h"
>  #include "parent.h"
> +#include "xfs/xfs_arch.h"
> +#include "xfs/xfs_format.h"

These headers should not be used in libhandle.  As mentioned last time I
think libhandle should get it's own LIBHANDLE_XATTR_LIST_MAX define,
separate frome the one for the on disk format.

<Prev in Thread] Current Thread [Next in Thread>