xfs
[Top] [All Lists]

Re: [PATCH 21/22] xfs: %pF is only for function pointers

To: Scott Wood <scottwood@xxxxxxxxxxxxx>
Subject: Re: [PATCH 21/22] xfs: %pF is only for function pointers
From: Steven Rostedt <rostedt@xxxxxxxxxxx>
Date: Mon, 31 Aug 2015 16:05:51 -0400
Cc: Dave Chinner <david@xxxxxxxxxxxxx>, <trivial@xxxxxxxxxx>, <linux-kernel@xxxxxxxxxxxxxxx>, <xfs@xxxxxxxxxxx>
Delivered-to: xfs@xxxxxxxxxxx
In-reply-to: <1441051104.4966.41.camel@xxxxxxxxxxxxx>
References: <1426130037-17956-1-git-send-email-scottwood@xxxxxxxxxxxxx> <1426130037-17956-21-git-send-email-scottwood@xxxxxxxxxxxxx> <20150831080657.GF26895@dastard> <1441049065.4966.38.camel@xxxxxxxxxxxxx> <20150831154521.1c9353b6@xxxxxxxxxxxxxxxxxx> <1441051104.4966.41.camel@xxxxxxxxxxxxx>
On Mon, 31 Aug 2015 14:58:24 -0500
Scott Wood <scottwood@xxxxxxxxxxxxx> wrote:

> > We can fix that with adding %ps to the traceevent library.
> 
> I wasn't sure if this would be considered a stable ABI issue, as it's not 
> about the events themselves, but about the event mechanism.

When it comes to trace events, there's a fine line about the use space
stable ABI. Even Linus has mentioned that tracing and perf counters are
"special", as the two are not about a feature of the kernel, but
instead a way to see how the kernel works internally.

I've fixed up trace-cmd and libtraceevent more than once in the past
due to changes in the kernel. Unless it truly breaks the tool, it
should be fine to fix up tracepoints to handle small changes like this.

-- Steve

<Prev in Thread] Current Thread [Next in Thread>