xfs
[Top] [All Lists]

[PATCH 01/11] xfs_repair: set args.geo in dir2_kill_block

To: david@xxxxxxxxxxxxx, darrick.wong@xxxxxxxxxx
Subject: [PATCH 01/11] xfs_repair: set args.geo in dir2_kill_block
From: "Darrick J. Wong" <darrick.wong@xxxxxxxxxx>
Date: Tue, 25 Aug 2015 17:32:27 -0700
Cc: Eric Sandeen <sandeen@xxxxxxxxxx>, xfs@xxxxxxxxxxx
Delivered-to: xfs@xxxxxxxxxxx
In-reply-to: <20150826003220.23973.59731.stgit@xxxxxxxxxxxxxxxx>
References: <20150826003220.23973.59731.stgit@xxxxxxxxxxxxxxxx>
User-agent: StGit/0.17.1-dirty
FrÃm: Eric Sandeen <sandeen@xxxxxxxxxxx>

This path in xfs_repair:

dir2_kill_block
        libxfs_da_shrink_inode
                xfs_dir2_shrink_inode
                        xfs_dir2_db_to_da

segfaults, because dir2_kill_block() does not initialize
args.geo, and a null geometry winds up in xfs_dir2_db_to_da(),
which dereferences it.

Fix that.

Signed-off-by: Eric Sandeen <sandeen@xxxxxxxxxx>
---
 repair/phase6.c |    1 +
 1 file changed, 1 insertion(+)


diff --git a/repair/phase6.c b/repair/phase6.c
index 04638c2..7e275cd 100644
--- a/repair/phase6.c
+++ b/repair/phase6.c
@@ -1444,6 +1444,7 @@ dir2_kill_block(
        args.firstblock = &firstblock;
        args.flist = &flist;
        args.whichfork = XFS_DATA_FORK;
+       args.geo = mp->m_dir_geo;
        if (da_bno >= mp->m_dir_geo->leafblk && da_bno < mp->m_dir_geo->freeblk)
                error = -libxfs_da_shrink_inode(&args, da_bno, bp);
        else

<Prev in Thread] Current Thread [Next in Thread>