xfs
[Top] [All Lists]

Re: [PATCH block/for-linus] writeback: fix syncing of I_DIRTY_TIME inode

To: Dave Chinner <david@xxxxxxxxxxxxx>
Subject: Re: [PATCH block/for-linus] writeback: fix syncing of I_DIRTY_TIME inodes
From: Tejun Heo <tj@xxxxxxxxxx>
Date: Mon, 24 Aug 2015 18:53:56 -0400
Cc: Eryu Guan <eguan@xxxxxxxxxx>, Jens Axboe <axboe@xxxxxxxxx>, Jan Kara <jack@xxxxxxx>, linux-kernel@xxxxxxxxxxxxxxx, xfs@xxxxxxxxxxx, axboe@xxxxxx, Jan Kara <jack@xxxxxxxx>, linux-fsdevel@xxxxxxxxxxxxxxx, kernel-team@xxxxxx
Delivered-to: xfs@xxxxxxxxxxx
Dkim-signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=sender:date:from:to:cc:subject:message-id:references:mime-version :content-type:content-disposition:in-reply-to:user-agent; bh=AYMhRc9N58yuF5lJ6Rw8ZPqRW0BL/25EI4B8UBiic4k=; b=is+gA2nA5IigGMA3w7UM241OXyM9ClXrSvadiAgS0NQP4j4jGfrxR2ZXinUCg6rlhK rniII3t1m+lg9+G/jHWSXH0gpK3grGD4NukdWQOdKZINSaettsjORWen819zZtZuJT2a xs+VKLTlenmwbYx23yP6x16XIc4Qb/oQhN6f9fP8PN26DZVlsT5+p/SkW5dDMTu/84It mmSiReyky27osgSFvK0gv1sqUml2k81/OtYm1/+Df3Sg0eZ7FTlCK7hZdo1yVsisyhb0 onahwdAeNgvVnQTURKYTDFGOI55nC/Y8KJd9iKD6ZoWhweQJed8OJh1xzeqoLwqqZkpv ym/w==
In-reply-to: <20150824222720.GD714@dastard>
References: <20150818174718.GA15739@xxxxxxxxxxxxxxx> <20150818195439.GB15739@xxxxxxxxxxxxxxx> <20150818215611.GD3902@dastard> <20150820061224.GG17933@xxxxxxxxxxxxxxxxxxxxxxxxxx> <20150820143626.GI17933@xxxxxxxxxxxxxxxxxxxxxxxxxx> <20150820143735.GJ17933@xxxxxxxxxxxxxxxxxxxxxxxxxx> <20150820165537.GA2044@xxxxxxxxxxxxxxx> <20150820230451.GT714@dastard> <20150824181038.GA28944@xxxxxxxxxxxxxxx> <20150824222720.GD714@dastard>
Sender: Tejun Heo <htejun@xxxxxxxxx>
User-agent: Mutt/1.5.23 (2014-03-12)
Hello, Dave.

On Tue, Aug 25, 2015 at 08:27:20AM +1000, Dave Chinner wrote:
> > I'm still a bit confused.  What prevents the following from happening?
> > 
> > 1. io completion of last dirty page of an inode and work item for
> >    xfs_setfilesize() is queued.
> > 
> > 2. inode removed from dirty list.
> 
> The inode has already been removed from the dirty list - that
> happens at inode writeback submission time, not IO completion.

Ah, yeah, right, somehow was thinking requeue_io() was being called
from completion path.  That's where I was confused.

Thanks.

-- 
tejun

<Prev in Thread] Current Thread [Next in Thread>