xfs
[Top] [All Lists]

Re: [PATCH block/for-linus] writeback: fix syncing of I_DIRTY_TIME inode

To: Dave Chinner <david@xxxxxxxxxxxxx>
Subject: Re: [PATCH block/for-linus] writeback: fix syncing of I_DIRTY_TIME inodes
From: Eryu Guan <eguan@xxxxxxxxxx>
Date: Mon, 24 Aug 2015 11:18:16 +0800
Cc: Jens Axboe <axboe@xxxxxxxxx>, Jan Kara <jack@xxxxxxx>, linux-kernel@xxxxxxxxxxxxxxx, xfs@xxxxxxxxxxx, axboe@xxxxxx, Tejun Heo <tj@xxxxxxxxxx>, Jan Kara <jack@xxxxxxxx>, linux-fsdevel@xxxxxxxxxxxxxxx, kernel-team@xxxxxx
Delivered-to: xfs@xxxxxxxxxxx
In-reply-to: <20150824011123.GA714@dastard>
References: <20150814111408.GB8710@xxxxxxxxxxxxx> <20150817200254.GG21075@xxxxxxxxxxxxxxx> <20150818091603.GA12317@xxxxxxxxxxxxx> <20150818174718.GA15739@xxxxxxxxxxxxxxx> <20150818195439.GB15739@xxxxxxxxxxxxxxx> <20150818215611.GD3902@dastard> <20150821102053.GL17933@xxxxxxxxxxxxxxxxxxxxxxxxxx> <20150822003025.GS3902@dastard> <20150822044609.GM17933@xxxxxxxxxxxxxxxxxxxxxxxxxx> <20150824011123.GA714@dastard>
User-agent: Mutt/1.5.23 (2014-03-12)
On Mon, Aug 24, 2015 at 11:11:23AM +1000, Dave Chinner wrote:
> 
> Eryu, can you change the way you run the event trace to be:
> 
> $ sudo trace-cmd <options> -o <outfile location> ./check <test options>
> 
> rather than running the trace as a background operation elsewhere?
> Maybe that will give better results.

The results are here

http://128.199.137.77/writeback-v3/

> 
> Also, it would be informative to us if you can reproduce this with a
> v5 filesystem (i.e. mkfs.xfs -m crc=1) because it has much better
> on-disk information for sequence-of-event triage like this. If you
> can reproduce it with a v5 filesystem, can you post the trace and
> metadump?

This seems to be harder to reproduce with tracepoints enabled, but I'll
keep trying, and the tests below.

Thanks,
Eryu

> 
> Other things to check (separately):
> 
>       - change godown to godown -f
>       - add a "sleep 5" before running godown after sync
>       - add a "sleep 5; sync" before running godown
> 
> i.e. I'm wondering if sync is not waiting for everything, and so we
> aren't capturing the IO completions because the filesystem is
> already shut down by the time they are delivered...
> 
> Cheers,
> 
> Dave.
> -- 
> Dave Chinner
> david@xxxxxxxxxxxxx
> 
> _______________________________________________
> xfs mailing list
> xfs@xxxxxxxxxxx
> http://oss.sgi.com/mailman/listinfo/xfs

<Prev in Thread] Current Thread [Next in Thread>