xfs
[Top] [All Lists]

Re: [PATCH] xfs: inode lockdep annotations broke non-lockdep build

To: Dave Chinner <david@xxxxxxxxxxxxx>
Subject: Re: [PATCH] xfs: inode lockdep annotations broke non-lockdep build
From: Brian Foster <bfoster@xxxxxxxxxx>
Date: Fri, 21 Aug 2015 07:09:06 -0400
Cc: xfs@xxxxxxxxxxx
Delivered-to: xfs@xxxxxxxxxxx
In-reply-to: <20150821004254.GV714@dastard>
References: <1439979814-18934-1-git-send-email-david@xxxxxxxxxxxxx> <20150820113200.GA13033@xxxxxxxxxxxxxxx> <20150821004254.GV714@dastard>
User-agent: Mutt/1.5.23 (2014-03-12)
On Fri, Aug 21, 2015 at 10:42:54AM +1000, Dave Chinner wrote:
> On Thu, Aug 20, 2015 at 07:32:00AM -0400, Brian Foster wrote:
> > On Wed, Aug 19, 2015 at 08:23:34PM +1000, Dave Chinner wrote:
> > > From: Dave Chinner <dchinner@xxxxxxxxxx>
> > > 
...
> 
> > Perhaps it's best to just use the #define in both cases?
> 
> -#ifdef CONFIG_LOCKDEP
> +#if (defined(DEBUG) || defined(XFS_WARN)) && CONFIG_LOCKDEP
> 
> is how I fixed it.
> 

Sounds good to me.

Brian

> Cheers,
> 
> Dave.
> -- 
> Dave Chinner
> david@xxxxxxxxxxxxx
> 
> _______________________________________________
> xfs mailing list
> xfs@xxxxxxxxxxx
> http://oss.sgi.com/mailman/listinfo/xfs

<Prev in Thread] Current Thread [Next in Thread>