xfs
[Top] [All Lists]

Re: [PATCH 02/11] xfsprogs: Add ifdef dirent checks where it was missing

To: Jan Tulak <jtulak@xxxxxxxxxx>
Subject: Re: [PATCH 02/11] xfsprogs: Add ifdef dirent checks where it was missing
From: Christoph Hellwig <hch@xxxxxxxxxxxxx>
Date: Mon, 17 Aug 2015 12:23:00 -0700
Cc: xfs@xxxxxxxxxxx, hch@xxxxxxxxxxxxx
Delivered-to: xfs@xxxxxxxxxxx
In-reply-to: <1439828606-7886-3-git-send-email-jtulak@xxxxxxxxxx>
References: <1439828606-7886-1-git-send-email-jtulak@xxxxxxxxxx> <1439828606-7886-3-git-send-email-jtulak@xxxxxxxxxx>
User-agent: Mutt/1.5.23 (2014-03-12)
On Mon, Aug 17, 2015 at 06:23:17PM +0200, Jan Tulak wrote:
> Add check for _DIRENT_HAVED_RECLEN/_OFF to read_directory().
> In dump_dirent() these checks already are used, but they were
> missing in read_directory.
> 
> Signed-off-by: Jan Tulak <jtulak@xxxxxxxxxx>

Looks fine,

Reviewed-by: Christoph Hellwig <hch@xxxxxx>

(and didn't I review this one previously?)

<Prev in Thread] Current Thread [Next in Thread>