Re: [PATCH 01/11] xfsprogs: undefined variable fix

To:	Jan Tulak <jtulak@xxxxxxxxxx>
Subject:	Re: [PATCH 01/11] xfsprogs: undefined variable fix
From:	Christoph Hellwig <hch@xxxxxxxxxxxxx>
Date:	Mon, 17 Aug 2015 12:22:28 -0700
Cc:	xfs@xxxxxxxxxxx, hch@xxxxxxxxxxxxx
Delivered-to:	xfs@xxxxxxxxxxx
In-reply-to:	<1439828606-7886-2-git-send-email-jtulak@xxxxxxxxxx>
References:	<1439828606-7886-1-git-send-email-jtulak@xxxxxxxxxx> <1439828606-7886-2-git-send-email-jtulak@xxxxxxxxxx>
User-agent:	Mutt/1.5.23 (2014-03-12)

On Mon, Aug 17, 2015 at 06:23:16PM +0200, Jan Tulak wrote:
> Typo fix, which wasn't caught earlier due to #ifdef branching.  The
> 'rmnttomname' does not exists anywhere and looks like a hybrid between
> rmntfromname and rmntonname. And because the previous 'if' has
> 'fromname' on both arguments of realpath, I choosed the same approach
> when fixing it.
> 
> Signed-off-by: Jan Tulak <jtulak@xxxxxxxxxx>

Looks good,

Reviewed-by: Christoph Hellwig <hch@xxxxxx>

<Prev in Thread]	Current Thread	[Next in Thread>
[PATCH 00/11] xfsprogs: Partial OS X support, Jan Tulak [PATCH 02/11] xfsprogs: Add ifdef dirent checks where it was missing, Jan Tulak Re: [PATCH 02/11] xfsprogs: Add ifdef dirent checks where it was missing, Christoph Hellwig Re: [PATCH 02/11] xfsprogs: Add ifdef dirent checks where it was missing, Jan Tulak [PATCH 03/11] xfsprogs: Change OS X-specific CFLAGS/LDFLAGS, Jan Tulak [PATCH 01/11] xfsprogs: undefined variable fix, Jan Tulak Re: [PATCH 01/11] xfsprogs: undefined variable fix, Christoph Hellwig <= [PATCH 05/11] xfsprogs: missing and dummy calls for OS X support, Jan Tulak Re: [PATCH 05/11] xfsprogs: missing and dummy calls for OS X support, Christoph Hellwig Re: [PATCH 05/11] xfsprogs: missing and dummy calls for OS X support, Dave Chinner Re: [PATCH 05/11] xfsprogs: missing and dummy calls for OS X support, Jan Tulak Re: [PATCH 05/11] xfsprogs: missing and dummy calls for OS X support, Dave Chinner Re: [PATCH 05/11] xfsprogs: missing and dummy calls for OS X support, Christoph Hellwig Re: [PATCH 05/11] xfsprogs: missing and dummy calls for OS X support, Jan Tulak Re: [PATCH 05/11] xfsprogs: missing and dummy calls for OS X support, Christoph Hellwig Re: [PATCH 05/11] xfsprogs: missing and dummy calls for OS X support, Dave Chinner Re: [PATCH 05/11] xfsprogs: missing and dummy calls for OS X support, Dave Chinner

Previous by Date:	Re: [PATCH] xfs: flush entire file on dio read/write to cached file, Christoph Hellwig
Next by Date:	Re: [PATCH 02/11] xfsprogs: Add ifdef dirent checks where it was missing, Christoph Hellwig
Previous by Thread:	[PATCH 01/11] xfsprogs: undefined variable fix, Jan Tulak
Next by Thread:	[PATCH 05/11] xfsprogs: missing and dummy calls for OS X support, Jan Tulak
Indexes:	[Date] [Thread] [Top] [All Lists]