xfs
[Top] [All Lists]

Re: [PATCH 1/8] xfs: Introduce writeback context for writepages

To: Christoph Hellwig <hch@xxxxxxxxxxxxx>
Subject: Re: [PATCH 1/8] xfs: Introduce writeback context for writepages
From: Dave Chinner <david@xxxxxxxxxxxxx>
Date: Sun, 16 Aug 2015 08:57:34 +1000
Cc: xfs@xxxxxxxxxxx
Delivered-to: xfs@xxxxxxxxxxx
In-reply-to: <20150815132336.GA7385@xxxxxxxxxxxxx>
References: <1439333388-16452-1-git-send-email-david@xxxxxxxxxxxxx> <1439333388-16452-2-git-send-email-david@xxxxxxxxxxxxx> <20150812072635.GA32399@xxxxxxxxxxxxx> <20150813013244.GP3902@dastard> <20150813065258.GA677@xxxxxxxxxxxxx> <20150814015309.GU3902@dastard> <20150815132336.GA7385@xxxxxxxxxxxxx>
User-agent: Mutt/1.5.21 (2010-09-15)
On Sat, Aug 15, 2015 at 06:23:36AM -0700, Christoph Hellwig wrote:
> On Fri, Aug 14, 2015 at 11:53:09AM +1000, Dave Chinner wrote:
> > Ok, I've gone back and had a look at this now and reminded myself of
> > the discussion we had and the problems found. The end results are
> > remarkably similar - maybe that's why I found it easy to write this
> > patch set. i.e. your patchset was buried somewhere in my brain, even
> > though I'd forgotten about it at the surface...
> > 
> > How would you like to see this patchset broken up into more
> > sensible/reviewable chunks? It's just folding and splitting patches,
> > so it's not a big deal to rework it...
> 
> I think it should be less.  Patch 3 should go first, and then 1,2,4 & 5
> as a single one.

No worries, I'll reorder and fold them, retest and repost. Thanks
Christoph!

-Dave.
-- 
Dave Chinner
david@xxxxxxxxxxxxx

<Prev in Thread] Current Thread [Next in Thread>