xfs
[Top] [All Lists]

Re: [PATCH v3 12/13] xfs: add helper to conditionally remove items from

To: Christoph Hellwig <hch@xxxxxxxxxxxxx>
Subject: Re: [PATCH v3 12/13] xfs: add helper to conditionally remove items from the AIL
From: Brian Foster <bfoster@xxxxxxxxxx>
Date: Wed, 12 Aug 2015 08:48:11 -0400
Cc: xfs@xxxxxxxxxxx
Delivered-to: xfs@xxxxxxxxxxx
In-reply-to: <20150812071727.GB14237@xxxxxxxxxxxxx>
References: <1439233309-19959-1-git-send-email-bfoster@xxxxxxxxxx> <1439233309-19959-13-git-send-email-bfoster@xxxxxxxxxx> <20150812071727.GB14237@xxxxxxxxxxxxx>
User-agent: Mutt/1.5.23 (2014-03-12)
On Wed, Aug 12, 2015 at 12:17:27AM -0700, Christoph Hellwig wrote:
> > +                   xfs_trans_ail_remove(lip->li_ailp, lip,
> > +                                        SHUTDOWN_LOG_IO_ERROR);
> 
> I'd say remove the ail argument, lip->li_ailp can be derferenced inside
> xfs_trans_ail_remove safely.

Ok.

Brian

<Prev in Thread] Current Thread [Next in Thread>