| To: | Dave Chinner <david@xxxxxxxxxxxxx> |
|---|---|
| Subject: | Re: [PATCH 3/8] xfs: remove nonblocking mode from xfs_vm_writepage |
| From: | Christoph Hellwig <hch@xxxxxxxxxxxxx> |
| Date: | Wed, 12 Aug 2015 00:27:42 -0700 |
| Cc: | xfs@xxxxxxxxxxx |
| Delivered-to: | xfs@xxxxxxxxxxx |
| In-reply-to: | <1439333388-16452-4-git-send-email-david@xxxxxxxxxxxxx> |
| References: | <1439333388-16452-1-git-send-email-david@xxxxxxxxxxxxx> <1439333388-16452-4-git-send-email-david@xxxxxxxxxxxxx> |
| User-agent: | Mutt/1.5.23 (2014-03-12) |
This error handling was the biggest obstacle last time we tried it, so let's remove it for now. However: On Wed, Aug 12, 2015 at 08:49:43AM +1000, Dave Chinner wrote: > Remove the nonblocking optimisation done for mapping lookups during > writeback. It's not clear that leaving a hole in the writeback range > just because we couldn't get a lock is really a win, as it makes us > do another small random IO later on rather than a large sequential > IO now. The fs-writeback.c will usually move to a different inode, so I don't think it's actually that bad. |
| Previous by Date: | Re: [PATCH 1/8] xfs: Introduce writeback context for writepages, Christoph Hellwig |
|---|---|
| Next by Date: | Re: [PATCH] libxfs: readahead of dir3 data blocks should use the read verifier, Christoph Hellwig |
| Previous by Thread: | [PATCH 3/8] xfs: remove nonblocking mode from xfs_vm_writepage, Dave Chinner |
| Next by Thread: | [PATCH 2/8] xfs: io type needs to be part of the writepage context, Dave Chinner |
| Indexes: | [Date] [Thread] [Top] [All Lists] |