xfs
[Top] [All Lists]

Re: [PATCH v3 12/13] xfs: add helper to conditionally remove items from

To: Brian Foster <bfoster@xxxxxxxxxx>
Subject: Re: [PATCH v3 12/13] xfs: add helper to conditionally remove items from the AIL
From: Christoph Hellwig <hch@xxxxxxxxxxxxx>
Date: Wed, 12 Aug 2015 00:17:27 -0700
Cc: xfs@xxxxxxxxxxx
Delivered-to: xfs@xxxxxxxxxxx
In-reply-to: <1439233309-19959-13-git-send-email-bfoster@xxxxxxxxxx>
References: <1439233309-19959-1-git-send-email-bfoster@xxxxxxxxxx> <1439233309-19959-13-git-send-email-bfoster@xxxxxxxxxx>
User-agent: Mutt/1.5.23 (2014-03-12)
> +                     xfs_trans_ail_remove(lip->li_ailp, lip,
> +                                          SHUTDOWN_LOG_IO_ERROR);

I'd say remove the ail argument, lip->li_ailp can be derferenced inside
xfs_trans_ail_remove safely.

<Prev in Thread] Current Thread [Next in Thread>