xfs
[Top] [All Lists]
<prev [Date] next>
[Advanced]
 <prev [Thread] next>

Re: [PATCH 06/11] xfs: don't leave EFIs on AIL on mount failure

from [Christoph Hellwig] [Permanent Link][Original]
To: Brian Foster <bfoster@xxxxxxxxxx>
Subject: Re: [PATCH 06/11] xfs: don't leave EFIs on AIL on mount failure
From: Christoph Hellwig <hch@xxxxxxxxxxxxx>
Date: Sun, 9 Aug 2015 01:01:50 -0700
Cc: xfs@xxxxxxxxxxx
Delivered-to: xfs@xxxxxxxxxxx
In-reply-to: <1438883072-28706-7-git-send-email-bfoster@xxxxxxxxxx>
References: <1438883072-28706-1-git-send-email-bfoster@xxxxxxxxxx> <1438883072-28706-7-git-send-email-bfoster@xxxxxxxxxx>
User-agent: Mutt/1.5.23 (2014-03-12) 
>  STATIC int
>  xlog_recover_process_efis(
> -     struct xlog     *log)
> +     struct xlog             *log,
> +     bool                    cancel)

There is almost no code shared between cancelation and processing,
so please add a new xlog_cancel_efis helper instead.

> +             efip = (struct xfs_efi_log_item *) lip;

Please use container_of to get to a containing structure.
[More with this subject...]
<Prev in Thread] Current Thread [Next in Thread>
Previous by Date:  Re: [PATCH 05/11] xfs: use EFI refcount consistently in log recovery, Christoph Hellwig
Next by Date:  Re: [PATCH 07/11] xfs: icreate log item recovery and cancellation tracepoints, Christoph Hellwig
Previous by Thread:  Re: [PATCH 06/11] xfs: don't leave EFIs on AIL on mount failure, Brian Foster
Next by Thread:  Re: [PATCH 06/11] xfs: don't leave EFIs on AIL on mount failure, Brian Foster
Indexes:  [Date] [Thread] [Top] [All Lists]