Re: [PATCH 03/11] xfs: fix efi/efd error handling to avoid fs shutdown hangs

[Christoph Hellwig <hch@xxxxxxxxxxxxx>]

>  STATIC void
>  xfs_efi_item_unpin(
> @@ -141,14 +147,6 @@ xfs_efi_item_unpin(
>       int                     remove)
>  {
>       struct xfs_efi_log_item *efip = EFI_ITEM(lip);
> -
> -     if (remove) {
> -             ASSERT(!(lip->li_flags & XFS_LI_IN_AIL));
> -             if (lip->li_desc)
> -                     xfs_trans_del_item(lip);
> -             xfs_efi_item_free(efip);
> -             return;
> -     }
>       xfs_efi_release(efip);

After this the buf iterm is the last one looking a the remove
argument.  I wonder if it might need similar treatment.

> -     return (xfs_lsn_t)-1;
> +
> +     return (xfs_lsn_t) -1;

This changes the style away from the most common style in Linux and XFS.