xfs
[Top] [All Lists]

Re: [PATCH] db: fix uninitialised variable warnings

To: Dave Chinner <david@xxxxxxxxxxxxx>
Subject: Re: [PATCH] db: fix uninitialised variable warnings
From: Brian Foster <bfoster@xxxxxxxxxx>
Date: Fri, 7 Aug 2015 07:37:06 -0400
Cc: xfs@xxxxxxxxxxx
Delivered-to: xfs@xxxxxxxxxxx
In-reply-to: <1438814992-31588-1-git-send-email-david@xxxxxxxxxxxxx>
References: <1438814992-31588-1-git-send-email-david@xxxxxxxxxxxxx>
User-agent: Mutt/1.5.23 (2014-03-12)
On Thu, Aug 06, 2015 at 08:49:52AM +1000, Dave Chinner wrote:
> From: Dave Chinner <dchinner@xxxxxxxxxx>
> 
> New versions of gcc barf on the conversion table code in
> db/convert.c. Shut it up by initialising the conversion array.
> 
> Signed-off-by: Dave Chinner <dchinner@xxxxxxxxxx>
> ---

Reviewed-by: Brian Foster <bfoster@xxxxxxxxxx>

>  db/convert.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/db/convert.c b/db/convert.c
> index 09f9225..a337abe 100644
> --- a/db/convert.c
> +++ b/db/convert.c
> @@ -157,7 +157,7 @@ convert_f(int argc, char **argv)
>  {
>       ctype_t         c;
>       int             conmask;
> -     cval_t          cvals[NCTS];
> +     cval_t          cvals[NCTS] = {};
>       int             i;
>       int             mask;
>       __uint64_t      v;
> -- 
> 2.1.4
> 
> _______________________________________________
> xfs mailing list
> xfs@xxxxxxxxxxx
> http://oss.sgi.com/mailman/listinfo/xfs

<Prev in Thread] Current Thread [Next in Thread>