Re: [PATCH 5/6] xfsprogs: use "unsigned short" instead of ushort

xfs

Re: [PATCH 5/6] xfsprogs: use "unsigned short" instead of ushort

To:	Theodore Ts'o <tytso@xxxxxxx>
Subject:	Re: [PATCH 5/6] xfsprogs: use "unsigned short" instead of ushort
From:	Christoph Hellwig <hch@xxxxxxxxxxxxx>
Date:	Thu, 30 Jul 2015 10:09:58 -0700
Cc:	xfs@xxxxxxxxxxx, fstests@xxxxxxxxxxxxxxx
Delivered-to:	xfs@xxxxxxxxxxx
In-reply-to:	<1437913255-7524-6-git-send-email-tytso@xxxxxxx>
References:	<1437913255-7524-1-git-send-email-tytso@xxxxxxx> <1437913255-7524-6-git-send-email-tytso@xxxxxxx>
User-agent:	Mutt/1.5.23 (2014-03-12)

On Sun, Jul 26, 2015 at 08:20:54AM -0400, Theodore Ts'o wrote:
> Android's bionic libc doesn't define ushort.  There isn't a real
> benefit (other than perhaps conciseness) to use ushort over "unsigned
> short", and it's only used in a handful of files in xfsprogs.  So
> change over to using unsigned short everywhere.

For the files shared with the kernel this should go into the kernel
first or at least at the same time.  Can you also send
a kernel patch to remove all uses of ushort under fs/xfs?

Otherwise looks fine:

Reviewed-by: Christoph Hellwig <hch@xxxxxx>

[More with this subject...]

<Prev in Thread]	Current Thread	[Next in Thread>
[PATCH 0/6] Add cross-compilation support for android, Theodore Ts'o [PATCH 5/6] xfsprogs: use "unsigned short" instead of ushort, Theodore Ts'o Re: [PATCH 5/6] xfsprogs: use "unsigned short" instead of ushort, Christoph Hellwig <= [PATCH 1/6] xfsprogs: define NBBY if not defined by the system header files, Theodore Ts'o Re: [PATCH 1/6] xfsprogs: define NBBY if not defined by the system header files, Christoph Hellwig [PATCH 3/6] xfsprogs: define and use BUILD_CC in configure.ac for cross compilation, Theodore Ts'o Re: [PATCH 3/6] xfsprogs: define and use BUILD_CC in configure.ac for cross compilation, Christoph Hellwig [PATCH 6/6] xfsprogs: add missing include of <stat.h>, Theodore Ts'o Re: [PATCH 6/6] xfsprogs: add missing include of <stat.h>, Christoph Hellwig [PATCH 2/6] xfsprogs: pull in libgen.h to get prototype for basename(), Theodore Ts'o Re: [PATCH 2/6] xfsprogs: pull in libgen.h to get prototype for basename(), Christoph Hellwig [PATCH 4/6] xfsprogs: avoid use of si_tid in struct xlog_split_item, Theodore Ts'o Re: [PATCH 4/6] xfsprogs: avoid use of si_tid in struct xlog_split_item, Christoph Hellwig

Previous by Date:	Re: [PATCH 1/6] xfsprogs: define NBBY if not defined by the system header files, Christoph Hellwig
Next by Date:	Re: [PATCH 6/6] xfsprogs: add missing include of <stat.h>, Christoph Hellwig
Previous by Thread:	[PATCH 5/6] xfsprogs: use "unsigned short" instead of ushort, Theodore Ts'o
Next by Thread:	[PATCH 1/6] xfsprogs: define NBBY if not defined by the system header files, Theodore Ts'o
Indexes:	[Date] [Thread] [Top] [All Lists]