On Wed, Jul 15, 2015 at 10:16:08AM +0200, Jan Kara wrote:
> xfs_alloc_fix_freelist() can sometimes jump to out_agbp_relse without
> ever setting value of 'error' variable which is then returned. This can
> happen e.g. when pag->pagf_init is set but AG is for metadata and we
> want to allocate user data.
>
> Fix the problem by initializing 'error' to 0, which is the desired
> return value when we decide to skip this group.
>
> CC: xfs@xxxxxxxxxxx
> Coverity-id: 1309714
> Signed-off-by: Jan Kara <jack@xxxxxxxx>
> ---
Reviewed-by: Brian Foster <bfoster@xxxxxxxxxx>
> fs/xfs/libxfs/xfs_alloc.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/fs/xfs/libxfs/xfs_alloc.c b/fs/xfs/libxfs/xfs_alloc.c
> index f9e9ffe6fb46..7f8f2a0d4567 100644
> --- a/fs/xfs/libxfs/xfs_alloc.c
> +++ b/fs/xfs/libxfs/xfs_alloc.c
> @@ -1937,7 +1937,7 @@ xfs_alloc_fix_freelist(
> struct xfs_alloc_arg targs; /* local allocation arguments */
> xfs_agblock_t bno; /* freelist block */
> xfs_extlen_t need; /* total blocks needed in freelist */
> - int error;
> + int error = 0;
>
> if (!pag->pagf_init) {
> error = xfs_alloc_read_agf(mp, tp, args->agno, flags, &agbp);
> --
> 2.1.4
>
> _______________________________________________
> xfs mailing list
> xfs@xxxxxxxxxxx
> http://oss.sgi.com/mailman/listinfo/xfs
|