| To: | SF Markus Elfring <elfring@xxxxxxxxxxxxxxxxxxxxx> |
|---|---|
| Subject: | Re: XFS: Fine-tuning for checks before the function call "xfs_qm_dqrele"? |
| From: | Dave Chinner <david@xxxxxxxxxxxxx> |
| Date: | Thu, 2 Jul 2015 10:19:51 +1000 |
| Cc: | xfs@xxxxxxxxxxx, LKML <linux-kernel@xxxxxxxxxxxxxxx>, kernel-janitors@xxxxxxxxxxxxxxx, Julia Lawall <julia.lawall@xxxxxxx> |
| Delivered-to: | xfs@xxxxxxxxxxx |
| In-reply-to: | <55939BA8.1090400@xxxxxxxxxxxxxxxxxxxxx> |
| References: | <530CF8FF.8080600@xxxxxxxxxxxxxxxxxxxxx> <alpine.DEB.2.02.1402252117150.2047@xxxxxxxxxxxxxxxxxxxxxxx> <530DD06F.4090703@xxxxxxxxxxxxxxxxxxxxx> <alpine.DEB.2.02.1402262129250.2221@xxxxxxxxxxxxxxxxxxxxxxx> <5317A59D.4@xxxxxxxxxxxxxxxxxxxxx> <5479F823.60900@xxxxxxxxxxxxxxxxxxxxx> <20141130230904.GF16151@dastard> <558D1833.3080009@xxxxxxxxxxxxxxxxxxxxx> <20150629214355.GE7943@dastard> <55939BA8.1090400@xxxxxxxxxxxxxxxxxxxxx> |
| User-agent: | Mutt/1.5.21 (2010-09-15) |
On Wed, Jul 01, 2015 at 09:50:00AM +0200, SF Markus Elfring wrote: > > xfs_dqrele_inode() gets called on every inode in the inode cache, > > and this change results in a cacheline in every inode being dirtied > > even if they don't have dquots attached. Given the inode cache can > > hold tens to hundreds of millions of inodes on large machines, we > > don't want to dirty any cachelines we don't need to while walking > > the inode cache and releasing dquots... > > Would it make sense to annotate checks before such function calls > as "LIKELY"? No - it will be random as to whether the inodes have dquots attached or not and so a static hint is always going to be wrong for someone.... Cheers, Dave. -- Dave Chinner david@xxxxxxxxxxxxx |
| <Prev in Thread] | Current Thread | [Next in Thread> |
|---|---|---|
| ||
| Previous by Date: | Re: [PATCH 10/14] xfs: minimize impact to non-reflink files via reflink per-inode flag, Dave Chinner |
|---|---|
| Next by Date: | Re: [PATCH 03/14] libxfs: support unmapping reflink blocks, Darrick J. Wong |
| Previous by Thread: | Re: XFS: Fine-tuning for checks before the function call "xfs_qm_dqrele"?, SF Markus Elfring |
| Next by Thread: | Re: [PATCH 13/17] mkfs: encode conflicts into parsing table, Jan Tulak |
| Indexes: | [Date] [Thread] [Top] [All Lists] |